Skip to content

Conversation

@artemmufazalov
Copy link
Member

@artemmufazalov artemmufazalov commented Jul 2, 2025

Closes #2497

Stand: https://nda.ya.ru/t/FfJLiROc7FzRMm

Palette: https://nda.ya.ru/t/X93Hbu647FzhFS

CI Results

Test Status: ⚠️ FLAKY

📊 Full Report

Total Passed Failed Flaky Skipped
354 352 0 1 1
Test Changes Summary ⏭️1

⏭️ Skipped Tests (1)

  1. Scroll to row, get shareable link, navigate to URL and verify row is scrolled into view (tenant/diagnostics/tabs/queries.test.ts)

Bundle Size: 🔺

Current: 84.01 MB | Main: 84.00 MB
Diff: +9.54 KB (0.01%)

⚠️ Bundle size increased. Please review.

ℹ️ CI Information
  • Test recordings for failed tests are available in the full report.
  • Bundle size is measured for the entire 'dist' directory.
  • 📊 indicates links to detailed reports.
  • 🔺 indicates increase, 🔽 decrease, and ✅ no change in bundle size.

{pollingInterval: autoRefreshInterval},
);
const versionToColor = useVersionToColorMap();
const versionToColor = useVersionToColorMap(cluster);
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

cluster param was forgot here, that's why the bar in Versions was always grey

@artemmufazalov artemmufazalov force-pushed the 2497-new-versions-colors branch from 7222df0 to 7e5707a Compare July 2, 2025 12:15
--versions-pink-4: #ffb0e1;
}
&_theme_dark,
&_theme_dark-hc {
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Frame 2087325961

@@ -0,0 +1,106 @@
.g-root {
&_theme_light,
&_theme_light-hc {
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Frame 2087325961 (1)

@forward './themes.scss';
@forward './unipika.scss';
@forward './illustrations.scss';
@forward './versions.scss';
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's important to not forget to import it in internal and EM version

@artemmufazalov artemmufazalov marked this pull request as ready for review July 2, 2025 16:51
@artemmufazalov artemmufazalov added this pull request to the merge queue Jul 3, 2025
Merged via the queue into main with commit a392546 Jul 3, 2025
8 checks passed
@artemmufazalov artemmufazalov deleted the 2497-new-versions-colors branch July 3, 2025 10:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Use new colors for versions

3 participants