-
Notifications
You must be signed in to change notification settings - Fork 17
feat!: update to uikit7 #2544
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat!: update to uikit7 #2544
Conversation
|
bugbot run |
|
|
Decided not to fix it right now, cause we want to get rid of this component (#2342) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
src/components/ContentWithPopup/ContentWithPopup.tsx
'onOutsideClick' is deprecated.ts(6385)
Popup.d.ts(69, 8): The declaration was marked as deprecated here.
(property) PopupProps.onOutsideClick?: ((event: MouseEvent) => void) | undefined
This callback will be called when click is outside of elements of "top layer" This behaviour could be disabled with disableOutsideClick option
@deprecated — Use onOpenChange instead
|
bugbot run |
|
bugbot run |
|
bugbot run |
|
bugbot run |
1 similar comment
|
bugbot run |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Bug: UsageLabel Component Overload Styling Missing
The UsageLabel component lost its overloadThreshold functionality during the UIKit migration. Previously, this prop (defaulting to 90) applied special "overload" styling when the value exceeded the threshold. The functionality was completely removed, including the overloadThreshold prop, its conditional styling logic, and associated SCSS, resulting in a loss of visual indication for high usage values.
src/components/UsageLabel/UsageLabel.tsx#L3-L14
ydb-embedded-ui/src/components/UsageLabel/UsageLabel.tsx
Lines 3 to 14 in 4d912d9
| interface UsageLabelProps extends Omit<LabelProps, 'value'> { | |
| value: number | string; | |
| } | |
| export function UsageLabel({value, theme, ...props}: UsageLabelProps) { | |
| return ( | |
| <Label theme={theme} {...props}> | |
| {value || 0}% | |
| </Label> | |
| ); | |
| } |
Was this report helpful? Give feedback by reacting with 👍 or 👎
closes #2144
Stand
CI Results
Test Status:⚠️ FLAKY
📊 Full Report
Test Changes Summary ⏭️2
⏭️ Skipped Tests (2)
Bundle Size: 🔺
Current: 85.06 MB | Main: 84.01 MB
Diff: +1.05 MB (1.26%)
ℹ️ CI Information