feat: add Queries activities banner #2549
Conversation
|
bugbot run |
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
|
bugbot run |
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
|
bugbot run |
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
|
bugbot run |
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
|
bugbot run |
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
astandrik
force-pushed
the
astandrik.2444
branch
from
5c6dcbe to
09477f6
Compare
| @@ -0,0 +1,10 @@ | |||
| { | |||
| "title": "Queries Activity", | |||
There was a problem hiding this comment.
lets use naming according to https://nda.ya.ru/t/3mmvfnW37GJ2rU
| border: none; | ||
| } | ||
|
|
||
| &_fullWidth { |
There was a problem hiding this comment.
why do you need it here? In components you pass width directly via styles property.
|
bugbot run |
This comment was marked as off-topic.
This comment was marked as off-topic.
Sorry, something went wrong.
| <div className={b('title')}>{title}</div> | ||
| <Flex className={b('title')} justifyContent="space-between" alignItems="center"> | ||
| <div>{title}</div> | ||
| {withTimeframeSelector && |
There was a problem hiding this comment.
what do u think about doing a prop like renderChartToolbar and pass whatever user of this component needs?
There was a problem hiding this comment.
I think its overengineering =)
There was a problem hiding this comment.
but why not ¯\_(ツ)_/¯
Closes #2444
Stand
CI Results
Test Status:⚠️ FLAKY
📊 Full Report
Test Changes Summary ⏭️2
⏭️ Skipped Tests (2)
Bundle Size: 🔺
Current: 85.11 MB | Main: 85.06 MB
Diff: +0.04 MB (0.05%)
ℹ️ CI Information