Skip to content

fix(TopicData): reset filters on partition change #2567

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jul 14, 2025
Merged

fix(TopicData): reset filters on partition change #2567

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
327e9f8
fix(TopicData): reset filters on partition change
Raubzeug Jul 14, 2025
19ea56e
fix: review
Raubzeug Jul 14, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 10 additions & 0 deletions src/containers/Tenant/Diagnostics/TopicData/TopicData.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -199,6 +199,14 @@ export function TopicData({scrollContainerRef, path, database}: TopicDataProps)
}
}, [handleSelectedOffsetChange, handleStartTimestampChange, topicDataFilter]);

const handlePartitionChange = React.useCallback(
(value: string[]) => {
handleSelectedPartitionChange(value[0]);
resetFilters();
},
[handleSelectedPartitionChange, resetFilters],
);

const scrollToOffset = React.useCallback(
(newOffset: number) => {
const scrollTop = (newOffset - (baseOffset ?? 0)) * DEFAULT_TABLE_ROW_HEIGHT;
Expand Down Expand Up @@ -241,6 +249,7 @@ export function TopicData({scrollContainerRef, path, database}: TopicDataProps)
key={controlsKey}
columnsToSelect={columnsToSelect}
handleSelectedColumnsUpdate={setColumns}
handlePartitionChange={handlePartitionChange}
partitions={partitions}
partitionsLoading={partitionsLoading}
partitionsError={partitionsError}
Expand All @@ -261,6 +270,7 @@ export function TopicData({scrollContainerRef, path, database}: TopicDataProps)
setColumns,
startOffset,
truncated,
handlePartitionChange,
]);

const renderEmptyDataMessage = () => {
Expand Down
24 changes: 4 additions & 20 deletions src/containers/Tenant/Diagnostics/TopicData/TopicDataControls/TopicDataControls.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -41,11 +41,13 @@ interface TopicDataControlsProps {
endOffset?: number;
truncatedData?: boolean;
scrollToOffset: (offset: number) => void;
handlePartitionChange?: (value: string[]) => void;
}

export function TopicDataControls({
columnsToSelect,
handleSelectedColumnsUpdate,
handlePartitionChange,

startOffset,
endOffset,
Expand All @@ -55,39 +57,21 @@ export function TopicDataControls({
scrollToOffset,
truncatedData,
}: TopicDataControlsProps) {
const {
selectedPartition,
handleSelectedPartitionChange: handleSelectedPartitionParamChange,
handleSelectedOffsetChange,
handleStartTimestampChange,
} = useTopicDataQueryParams();
const {selectedPartition} = useTopicDataQueryParams();

const partitionsToSelect = partitions?.map(({partitionId}) => ({
content: String(partitionId),
value: String(partitionId),
}));

const handleSelectedPartitionChange = React.useCallback(
(value: string[]) => {
handleSelectedPartitionParamChange(value[0]);
handleSelectedOffsetChange(undefined);
handleStartTimestampChange(undefined);
},
[
handleSelectedPartitionParamChange,
handleStartTimestampChange,
handleSelectedOffsetChange,
],
);

return (
<React.Fragment>
<Select
className={b('partition-select')}
label={i18n('label_partition-id')}
options={partitionsToSelect}
value={selectedPartition ? [selectedPartition] : undefined}
onUpdate={handleSelectedPartitionChange}
onUpdate={handlePartitionChange}
filterable={partitions && partitions.length > 5}
disabled={!partitions || !partitions.length}
errorPlacement="inside"
Expand Down
Loading