Skip to content

feat: redesign Memory section #2627

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 13 commits into from
Jul 29, 2025
Merged

feat: redesign Memory section #2627

merged 13 commits into from
Jul 29, 2025

Conversation

@astandrik
Copy link
Collaborator

@astandrik astandrik commented Jul 28, 2025 •
edited by github-actions bot
Loading

Closes #2447

Stand

CI Results

Test Status: ⚠️ FLAKY

📊 Full Report

Total Passed Failed Flaky Skipped
354 348 0 4 2
Test Changes Summary ⏭️2

⏭️ Skipped Tests (2)

  1. Scroll to row, get shareable link, navigate to URL and verify row is scrolled into view (tenant/diagnostics/tabs/queries.test.ts)
  2. Copy result button copies to clipboard (tenant/queryEditor/queryEditor.test.ts)

Bundle Size: 🔺

Current: 85.31 MB | Main: 85.29 MB
Diff: +0.03 MB (0.03%)

⚠️ Bundle size increased. Please review.

ℹ️ CI Information
  • Test recordings for failed tests are available in the full report.
  • Bundle size is measured for the entire 'dist' directory.
  • 📊 indicates links to detailed reports.
  • 🔺 indicates increase, 🔽 decrease, and ✅ no change in bundle size.

@astandrik astandrik marked this pull request as ready for review July 28, 2025 13:42
@astandrik astandrik requested a review from Copilot July 28, 2025 13:42
@astandrik
Copy link
Collaborator Author

astandrik commented Jul 28, 2025

bugbot run

This comment was marked as outdated.

Sign in to view

cursor[bot]
cursor bot reviewed Jul 28, 2025
View reviewed changes
Copy link

@cursor cursor bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Bugbot free trial expires on July 29, 2025
Learn more in the Cursor dashboard.

@astandrik astandrik requested a review from Copilot July 28, 2025 14:16
@astandrik
Copy link
Collaborator Author

astandrik commented Jul 28, 2025

bugbot run

This comment was marked as outdated.

Sign in to view

Raubzeug
Raubzeug requested changes Jul 28, 2025
View reviewed changes
src/components/ProgressWrapper/progressUtils.ts
export const PROGRESS_SIZE = 's';

export const isValidValue = (val?: number | string): boolean =>
isNumeric(val) && safeParseNumber(val) >= 0;
Copy link
Contributor

@Raubzeug Raubzeug Jul 28, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

safeParseNumber(val) always return value >=0, seems to be redundant check

Copy link
Collaborator Author

@astandrik astandrik Jul 28, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

value may be negative

src/containers/Tenant/Diagnostics/TenantOverview/TenantMemory/MemoryDetailsSection.scss Outdated
height: 10px;
}

&__popup-legend {
Copy link
Contributor

@Raubzeug Raubzeug Jul 28, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

never used

src/containers/Tenant/Diagnostics/TenantOverview/TenantMemory/MemoryDetailsSection.scss Outdated
border-radius: var(--g-border-radius-xs);
}

&__popup-name {
Copy link
Contributor

@Raubzeug Raubzeug Jul 28, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

never used

src/containers/Tenant/Diagnostics/TenantOverview/TenantMemory/MemoryDetailsSection.scss
&__segment-progress {
flex-shrink: 0;

width: 400px;
Copy link
Contributor

@Raubzeug Raubzeug Jul 28, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

maybe reduce? 100px seems to be enough

Screenshot 2025-07-28 at 18 08 39

Copy link
Collaborator Author

@astandrik astandrik Jul 28, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

image

Copy link
Collaborator Author

@astandrik astandrik Jul 28, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

will make 50%

Copy link
Collaborator Author

@astandrik astandrik Jul 29, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

gravity-ui/uikit#2353

@astandrik astandrik requested a review from Copilot July 29, 2025 09:37
@astandrik
Copy link
Collaborator Author

astandrik commented Jul 29, 2025

bugbot run

Copilot AI reviewed Jul 29, 2025
View reviewed changes
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR redesigns the Memory section of the YDB Embedded UI to improve its visual presentation and reusability. The main purpose is to create a more consistent and flexible progress display system while maintaining internationalization standards.

Key changes include:

  • Extracted and generalized progress wrapper components from TenantStorage for reuse across memory and storage sections
  • Redesigned memory details display with improved layout using definition lists and enhanced styling
  • Migrated i18n strings to follow project conventions with proper keyset registration

Reviewed Changes

Copilot reviewed 24 out of 25 changed files in this pull request and generated 4 comments.

Show a summary per file
File Description
src/utils/progress.ts Fixed potential null/undefined handling in formatValue function
src/containers/Tenant/Diagnostics/TenantOverview/i18n/en.json Added new i18n entries for memory details section
src/containers/Tenant/Diagnostics/TenantOverview/TenantStorage/* Removed local ProgressWrapper and constants, migrated to shared components
src/containers/Tenant/Diagnostics/TenantOverview/TenantMemory/* Complete redesign with new memory details section and improved styling
src/components/ProgressWrapper/* New shared progress wrapper component system with single/stack progress support
src/components/MemoryViewer/* Enhanced with exported utilities and color constants for better reusability

@astandrik
Copy link
Collaborator Author

astandrik commented Jul 29, 2025

bugbot run

@ydb-platform ydb-platform deleted a comment from cursor bot Jul 29, 2025
@astandrik astandrik requested a review from Raubzeug July 29, 2025 09:44
Raubzeug
Raubzeug previously approved these changes Jul 29, 2025
View reviewed changes
@astandrik astandrik added this pull request to the merge queue Jul 29, 2025
Merged via the queue into main with commit 437a81c Jul 29, 2025
11 of 15 checks passed
@astandrik astandrik deleted the astandrik.2447-4 branch July 29, 2025 11:37
@ydb-platform-bot ydb-platform-bot mentioned this pull request Jul 29, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

Copilot code review Copilot Copilot left review comments

@cursor cursor[bot] cursor[bot] left review comments

@Raubzeug Raubzeug Raubzeug approved these changes

@artemmufazalov artemmufazalov Awaiting requested review from artemmufazalov artemmufazalov is a code owner

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

redesign Memory section

3 participants

@astandrik @Raubzeug