fix: design refinements of query banner #2630
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
astandrik
force-pushed
the
astandrik.2623
branch
from
406679f to
2b9a61a
Compare
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
|
bugbot run |
There was a problem hiding this comment.
Pull Request Overview
This PR refactors the QueriesActivityBar component to provide better handling of chart availability and visual improvements. The changes improve the user experience by showing appropriate UI states when charts are not available and reorganizing the component structure.
Key changes include:
- Component refactoring with separation of concerns for different UI states
- Addition of chart availability detection to prevent hidden components
- New compact alert-style mode when charts are unavailable
Reviewed Changes
Copilot reviewed 11 out of 11 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
src/store/reducers/query/__test__/tabPersistence.test.tsx |
Updated test syntax from it to test for consistency |
src/components/QueriesActivityBar/useQueriesActivityData.ts |
New hook extracting data fetching logic from main component |
src/components/QueriesActivityBar/useChartAvailability.ts |
New hook to detect chart API availability without rendering components |
src/components/QueriesActivityBar/QueriesActivitySkeleton.tsx |
New skeleton component for loading state |
src/components/QueriesActivityBar/QueriesActivityExpandable.tsx |
New component for expandable mode when charts are available |
src/components/QueriesActivityBar/QueriesActivityCharts.tsx |
Updated chart layout using Flex components and adjusted heights |
src/components/QueriesActivityBar/QueriesActivityBar.tsx |
Refactored main component to orchestrate different UI states |
src/components/QueriesActivityBar/QueriesActivityAlert.tsx |
New compact alert component for when charts are unavailable |
src/components/QueriesActivityBar/QueriesActivityBar.scss |
Simplified styles removing redundant CSS rules |
src/components/QueriesActivityBar/QueriesActivityAlert.scss |
Styles for the new alert component |
|
Stand redeployed |
Raubzeug
requested changes
Jul 30, 2025
| @@ -0,0 +1,32 @@ | |||
| @use '../../styles/mixins.scss'; | |||
| } | ||
|
|
||
| // Render compact alert-style mode when charts are not available | ||
| if (areChartsAvailable === false) { |
There was a problem hiding this comment.
null - Still loading
Raubzeug
approved these changes
Jul 30, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #2623
Flat banner
Expandable banner
CI Results
Test Status:⚠️ FLAKY
📊 Full Report
Test Changes Summary ⏭️2
⏭️ Skipped Tests (2)
Bundle Size: 🔺
Current: 85.33 MB | Main: 85.31 MB
Diff: +0.01 MB (0.01%)
ℹ️ CI Information