-
Notifications
You must be signed in to change notification settings - Fork 17
feat: enable cluster events tab #2710
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
b3cab2e to
87e63fd
Compare
87e63fd to
99873f5
Compare
99873f5 to
0f2ce65
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR enables the cluster events tab functionality by adding the necessary infrastructure to conditionally show an events tab in the cluster interface. The feature is gated behind both a capability check and UI factory availability.
Key changes:
- Added capability detection for the
/meta/eventsendpoint - Implemented conditional rendering of the events tab based on feature availability
- Internationalized cluster tab titles using the i18n system
Reviewed Changes
Copilot reviewed 6 out of 6 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| src/uiFactory/types.ts | Added optional renderEvents method to UI factory interface |
| src/types/api/capabilities.ts | Added /meta/events capability type definition |
| src/store/reducers/capabilities/hooks.ts | Added hook to check cluster events availability |
| src/containers/Cluster/utils.tsx | Added events tab configuration and conditional display logic |
| src/containers/Cluster/i18n/en.json | Added internationalized tab titles |
| src/containers/Cluster/Cluster.tsx | Integrated events tab into cluster component with conditional routing |
|
@claude check i18n naming conventions if they follow instructions in document |
|
Claude finished @astandrik's task —— View job i18n Naming Convention ReviewI've reviewed the i18n changes in this PR against the naming conventions defined in Todo List:
Review ResultsThe PR adds 7 new i18n keys for tab titles:
❌ Naming Convention ViolationsAll new keys violate the documented naming conventions:
✅ Correct FormatThe keys should be renamed to follow the
Note: I also noticed that |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@artemmufazalov check please if you agree with comment about naming conventions - I asked claude to check if they follow our rules and it found some mismatches with current rulesets
There are already |
Part of #2670
CI Results
Test Status:⚠️ FLAKY
📊 Full Report
Test Changes Summary ⏭️2
⏭️ Skipped Tests (2)
Bundle Size: ✅
Current: 85.37 MB | Main: 85.37 MB
Diff: +4.28 KB (0.00%)
✅ Bundle size unchanged.
ℹ️ CI Information