Skip to content

Conversation

@artemmufazalov
Copy link
Member

@artemmufazalov artemmufazalov commented Aug 14, 2025

Part of #2670

CI Results

Test Status: ⚠️ FLAKY

📊 Full Report

Total Passed Failed Flaky Skipped
378 373 0 3 2
Test Changes Summary ⏭️2

⏭️ Skipped Tests (2)

  1. Scroll to row, get shareable link, navigate to URL and verify row is scrolled into view (tenant/diagnostics/tabs/queries.test.ts)
  2. Copy result button copies to clipboard (tenant/queryEditor/queryEditor.test.ts)

Bundle Size: ✅

Current: 85.37 MB | Main: 85.37 MB
Diff: +4.28 KB (0.00%)

✅ Bundle size unchanged.

ℹ️ CI Information
  • Test recordings for failed tests are available in the full report.
  • Bundle size is measured for the entire 'dist' directory.
  • 📊 indicates links to detailed reports.
  • 🔺 indicates increase, 🔽 decrease, and ✅ no change in bundle size.

This comment was marked as outdated.

This comment was marked as outdated.

Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR enables the cluster events tab functionality by adding the necessary infrastructure to conditionally show an events tab in the cluster interface. The feature is gated behind both a capability check and UI factory availability.

Key changes:

  • Added capability detection for the /meta/events endpoint
  • Implemented conditional rendering of the events tab based on feature availability
  • Internationalized cluster tab titles using the i18n system

Reviewed Changes

Copilot reviewed 6 out of 6 changed files in this pull request and generated no comments.

Show a summary per file
File Description
src/uiFactory/types.ts Added optional renderEvents method to UI factory interface
src/types/api/capabilities.ts Added /meta/events capability type definition
src/store/reducers/capabilities/hooks.ts Added hook to check cluster events availability
src/containers/Cluster/utils.tsx Added events tab configuration and conditional display logic
src/containers/Cluster/i18n/en.json Added internationalized tab titles
src/containers/Cluster/Cluster.tsx Integrated events tab into cluster component with conditional routing

@artemmufazalov artemmufazalov marked this pull request as ready for review August 20, 2025 19:52
cursor[bot]

This comment was marked as off-topic.

@ydb-platform ydb-platform deleted a comment from claude bot Aug 21, 2025
@astandrik
Copy link
Collaborator

@claude check i18n naming conventions if they follow instructions in document

@claude
Copy link

claude bot commented Aug 21, 2025

Claude finished @astandrik's task —— View job


i18n Naming Convention Review

I've reviewed the i18n changes in this PR against the naming conventions defined in i18n-naming-ruleset.md.

Todo List:

  • Read i18n-naming-ruleset.md to understand naming conventions
  • Review i18n changes in src/containers/Cluster/i18n/en.json
  • Check if new i18n keys follow the documented conventions
  • Provide feedback on compliance or violations

Review Results

The PR adds 7 new i18n keys for tab titles:

  • tab_tenants: "Databases"
  • tab_nodes: "Nodes"
  • tab_storage: "Storage"
  • tab_network: "Network"
  • tab_versions: "Versions"
  • tab_tablets: "Tablets"
  • tab_events: "Events"

❌ Naming Convention Violations

All new keys violate the documented naming conventions:

  1. Incorrect prefix: Keys use tab_ prefix which is not in the allowed list. According to the rules (section 2.2), only these prefixes are allowed:

    • context, alert, action, field, title, confirm, value
  2. Should use title_ prefix: Since these are tab titles (titles of sections/pages), they should use the title_ prefix as specified in the documentation:

    title - Titles of sections, pages, popups, menu items

✅ Correct Format

The keys should be renamed to follow the <context>_<content> pattern:

  • tab_tenantstitle_databases
  • tab_nodestitle_nodes
  • tab_storagetitle_storage
  • tab_networktitle_network
  • tab_versionstitle_versions
  • tab_tabletstitle_tablets
  • tab_eventstitle_events

Note: I also noticed that title_tenants would be more consistent with the actual tab content rather than title_databases, but that depends on your product terminology.

Copy link
Collaborator

@astandrik astandrik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@artemmufazalov check please if you agree with comment about naming conventions - I asked claude to check if they follow our rules and it found some mismatches with current rulesets

@artemmufazalov
Copy link
Member Author

@artemmufazalov check please if you agree with comment about naming conventions - I asked claude to check if they follow our rules and it found some mismatches with current rulesets

There are already title_ keysets with similar keys and values form Cluster overview dashboard there. tab_ keys are good here, since they are easily distinguishable from others

@artemmufazalov artemmufazalov added this pull request to the merge queue Aug 21, 2025
Merged via the queue into main with commit 2e3fb59 Aug 21, 2025
7 checks passed
@artemmufazalov artemmufazalov deleted the 2670-events branch August 21, 2025 11:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants