Skip to content

Conversation

@artemmufazalov
Copy link
Member

@artemmufazalov artemmufazalov commented Aug 20, 2025

I have a bug with the drawer when I use embedded ui as a package in dev mode.

The reason - drawer styles are in index.scss, which is not imported in other versions, because it has different fonts and forwards theme, that sometimes is not needed.

I moved drawer styles to a separate file, imported drawer, versions and unipika styles inside App.scss, so they are always imported and I don't need to import them manually. I didn't changed import of illustrations, assuming they may have different styles in different installations

Screenshot 2025-08-20 at 21 24 37

CI Results

Test Status: ⚠️ FLAKY

📊 Full Report

Total Passed Failed Flaky Skipped
378 374 0 2 2
Test Changes Summary ⏭️2

⏭️ Skipped Tests (2)

  1. Scroll to row, get shareable link, navigate to URL and verify row is scrolled into view (tenant/diagnostics/tabs/queries.test.ts)
  2. Copy result button copies to clipboard (tenant/queryEditor/queryEditor.test.ts)

Bundle Size: ✅

Current: 85.37 MB | Main: 85.37 MB
Diff: +0.11 KB (0.00%)

✅ Bundle size unchanged.

ℹ️ CI Information
  • Test recordings for failed tests are available in the full report.
  • Bundle size is measured for the entire 'dist' directory.
  • 📊 indicates links to detailed reports.
  • 🔺 indicates increase, 🔽 decrease, and ✅ no change in bundle size.

@artemmufazalov artemmufazalov added this pull request to the merge queue Aug 21, 2025
Merged via the queue into main with commit b2fd583 Aug 21, 2025
7 checks passed
@artemmufazalov artemmufazalov deleted the fix-drawer branch August 21, 2025 08:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants