fix: import components styles in App scss #2737
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I have a bug with the drawer when I use embedded ui as a package in dev mode.
The reason - drawer styles are in
index.scss, which is not imported in other versions, because it has different fonts and forwards theme, that sometimes is not needed.I moved drawer styles to a separate file, imported drawer, versions and unipika styles inside
App.scss, so they are always imported and I don't need to import them manually. I didn't changed import of illustrations, assuming they may have different styles in different installationsCI Results
Test Status:⚠️ FLAKY
📊 Full Report
Test Changes Summary ⏭️2
⏭️ Skipped Tests (2)
Bundle Size: ✅
Current: 85.37 MB | Main: 85.37 MB
Diff: +0.11 KB (0.00%)
✅ Bundle size unchanged.
ℹ️ CI Information