Skip to content

Conversation

@artemmufazalov
Copy link
Member

@artemmufazalov artemmufazalov commented Aug 20, 2025

Copy buttons in selected rows in partitions have wrong background.

Deleted additional background colors from EntityStatus styles, it seems everything OK without them.

Screenshot 2025-08-21 at 01 02 58

CI Results

Test Status: ⚠️ FLAKY

📊 Full Report

Total Passed Failed Flaky Skipped
378 373 0 3 2
Test Changes Summary ⏭️2

⏭️ Skipped Tests (2)

  1. Scroll to row, get shareable link, navigate to URL and verify row is scrolled into view (tenant/diagnostics/tabs/queries.test.ts)
  2. Copy result button copies to clipboard (tenant/queryEditor/queryEditor.test.ts)

Bundle Size: ✅

Current: 85.37 MB | Main: 85.37 MB
Diff: 0.30 KB (-0.00%)

✅ Bundle size unchanged.

ℹ️ CI Information
  • Test recordings for failed tests are available in the full report.
  • Bundle size is measured for the entire 'dist' directory.
  • 📊 indicates links to detailed reports.
  • 🔺 indicates increase, 🔽 decrease, and ✅ no change in bundle size.

@artemmufazalov artemmufazalov requested a review from Copilot August 20, 2025 22:07
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR fixes a visual issue where copy buttons in selected table rows for partitions had incorrect background colors. The fix removes unnecessary background color styles from the EntityStatus component that were interfering with proper table row styling.

  • Removes hardcoded background colors from EntityStatus buttons in visible and hover states
  • Allows table row selection styling to work properly without background color conflicts

@artemmufazalov artemmufazalov marked this pull request as ready for review August 20, 2025 22:10
@artemmufazalov artemmufazalov added this pull request to the merge queue Aug 21, 2025
Merged via the queue into main with commit 4474b34 Aug 21, 2025
7 checks passed
@artemmufazalov artemmufazalov deleted the fix-buttons-bg-in-selected-rows branch August 21, 2025 08:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants