fix: prevent render API calls when GraphShardExists=false #2743
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prevents unnecessary API calls to
/viewer/json/renderwhen the GraphShardExists capability is disabled.Problem
Previously, MetricChart components would make API calls to the
/viewer/json/renderendpoint regardless of whether GraphShard was enabled in the database capabilities. This resulted in:While the UI would hide charts when GraphShardExists=false, the underlying API calls were still being made.
Solution
Added a capability check to MetricChart that uses RTK Query's
skipoption to conditionally prevent API calls:Behavior
When GraphShardExists=true:
When GraphShardExists=false:
/viewer/json/renderare madeImpact
This change addresses the root cause more efficiently than the previous approach of making API calls and then conditionally displaying results.
💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.