feat(api): support object path manipulation #2786
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Raubzeug
requested review from
adameat,
artemmufazalov and
astandrik
as code owners
There was a problem hiding this comment.
Pull Request Overview
This PR adds object path manipulation support to the YDB Embedded UI API layer. The implementation introduces a new getSchemaPath method to the base API class and updates multiple viewer API methods to use this path transformation instead of passing paths directly.
- Adds
getSchemaPathmethod toBaseYdbAPIclass for path manipulation - Updates 12 viewer API methods to use the new path transformation
- Maintains backward compatibility with current path handling
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| src/services/api/base.ts | Adds getSchemaPath method to base API class for path manipulation |
| src/services/api/viewer.ts | Updates all viewer API methods to use getSchemaPath for path parameter transformation |
| getPath(path: string) { | ||
| return `${BACKEND ?? ''}${path}`; | ||
| } | ||
|
|
There was a problem hiding this comment.
The getSchemaPath method lacks documentation explaining its purpose, parameters, and return value. Add JSDoc comments to clarify the method's role in path manipulation and how it should be overridden in subclasses.
artemmufazalov
approved these changes
Sep 1, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #2778
CI Results
Test Status:⚠️ FLAKY
📊 Full Report
Test Changes Summary ⏭️2
⏭️ Skipped Tests (2)
Bundle Size: ✅
Current: 85.38 MB | Main: 85.38 MB
Diff: +1.53 KB (0.00%)
✅ Bundle size unchanged.
ℹ️ CI Information