Skip to content

Conversation

@artemmufazalov
Copy link
Member

@artemmufazalov artemmufazalov commented Sep 2, 2025

CI Results

Test Status: ⚠️ FLAKY

📊 Full Report

Total Passed Failed Flaky Skipped
378 373 0 3 2
Test Changes Summary ⏭️2

⏭️ Skipped Tests (2)

  1. Scroll to row, get shareable link, navigate to URL and verify row is scrolled into view (tenant/diagnostics/tabs/queries.test.ts)
  2. Copy result button copies to clipboard (tenant/queryEditor/queryEditor.test.ts)

Bundle Size: ✅

Current: 85.39 MB | Main: 85.38 MB
Diff: +0.51 KB (0.00%)

✅ Bundle size unchanged.

ℹ️ CI Information
  • Test recordings for failed tests are available in the full report.
  • Bundle size is measured for the entire 'dist' directory.
  • 📊 indicates links to detailed reports.
  • 🔺 indicates increase, 🔽 decrease, and ✅ no change in bundle size.

Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR enforces strict parameter passing requirements for the YdbEmbeddedAPI constructor to prevent configuration issues when the package is used in external installations. The change requires all configuration parameters to be explicitly provided rather than relying on optional parameters with defaults.

  • Converts optional API constructor parameters to required fields with explicit undefined values
  • Refactors type definitions to use proper type aliases for better maintainability
  • Updates the constructor signature to enforce explicit parameter passing

Reviewed Changes

Copilot reviewed 5 out of 5 changed files in this pull request and generated 2 comments.

Show a summary per file
File Description
src/uiFactory/types.ts Extracts inline type definitions to proper type aliases for renderBackups and renderEvents
src/store/configureStore.ts Adds explicit values for new required API parameters
src/services/api/meta.ts Updates constructor to require explicit parameter passing
src/services/api/index.ts Defines strict interface requiring all parameters and updates constructor signature
src/services/api/base.ts Updates base class constructor to require explicit parameter passing

@artemmufazalov artemmufazalov marked this pull request as ready for review September 2, 2025 10:40
@artemmufazalov artemmufazalov added this pull request to the merge queue Sep 2, 2025
Merged via the queue into main with commit fb48f49 Sep 2, 2025
7 checks passed
@artemmufazalov artemmufazalov deleted the api-require-fields branch September 2, 2025 10:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants