Skip to content

Conversation

@astandrik
Copy link
Collaborator

@astandrik astandrik commented Sep 2, 2025

Closes #2711

Stand

CI Results

Test Status: ⚠️ FLAKY

📊 Full Report

Total Passed Failed Flaky Skipped
378 373 0 3 2
Test Changes Summary ⏭️2

⏭️ Skipped Tests (2)

  1. Scroll to row, get shareable link, navigate to URL and verify row is scrolled into view (tenant/diagnostics/tabs/queries.test.ts)
  2. Copy result button copies to clipboard (tenant/queryEditor/queryEditor.test.ts)

Bundle Size: ✅

Current: 85.39 MB | Main: 85.39 MB
Diff: +2.22 KB (0.00%)

✅ Bundle size unchanged.

ℹ️ CI Information
  • Test recordings for failed tests are available in the full report.
  • Bundle size is measured for the entire 'dist' directory.
  • 📊 indicates links to detailed reports.
  • 🔺 indicates increase, 🔽 decrease, and ✅ no change in bundle size.

Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR fixes a "disco dance" issue with rack groups by implementing dynamic table offset calculation in the PaginatedTable component. The fix addresses visual jumping/repositioning problems that occur when table groups expand or collapse by computing real-time DOM-based offsets instead of using static cached values.

Key changes:

  • Replaced static tableOffset calculation with dynamic DOM-based offset computation
  • Added offscreen detection to freeze updates for tables outside the viewport
  • Improved scroll-based virtualization with better performance and stability

Reviewed Changes

Copilot reviewed 4 out of 4 changed files in this pull request and generated 2 comments.

File Description
src/components/PaginatedTable/utils.tsx Replaced calculateElementOffsetTop with getCurrentTableOffset and added isTableOffscreen utility for dynamic offset calculation
src/components/PaginatedTable/useScrollBasedChunks.ts Updated hook to use dynamic offset calculation and added offscreen freeze logic with comprehensive documentation
src/components/PaginatedTable/TableChunksRenderer.tsx Removed tableOffset prop dependency as it's now calculated dynamically
src/components/PaginatedTable/PaginatedTable.tsx Removed static tableOffset state and related useLayoutEffect for calculating table position

cursor[bot]

This comment was marked as off-topic.

@ydb-platform ydb-platform deleted a comment from claude bot Sep 2, 2025
@astandrik astandrik added this pull request to the merge queue Sep 2, 2025
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to no response for status checks Sep 2, 2025
@astandrik astandrik added this pull request to the merge queue Sep 2, 2025
Merged via the queue into main with commit 9b35acd Sep 2, 2025
8 checks passed
@astandrik astandrik deleted the astandrik.2711-2 branch September 2, 2025 16:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

fix: Rack groups disco dance

3 participants