-
Notifications
You must be signed in to change notification settings - Fork 17
fix: query tables styles #2815
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: query tables styles #2815
Conversation
|
@Raubzeug reported some problem with full screen results - investigating |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR fixes styling issues with query result tables by removing unnecessary flex display properties and improving fullscreen handling. The changes focus on resolving layout problems that were affecting table display in query results.
Key changes:
- Removed manual resize event dispatching from ResultSetsViewer component
- Simplified CSS flex display properties in ResizeableDataTable
- Added proper fullscreen resize handling in the Fullscreen component
Reviewed Changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| src/containers/Tenant/Query/QueryResult/components/ResultSetsViewer/ResultSetsViewer.tsx | Removed fullscreen state handling and manual resize event dispatching |
| src/components/ResizeableDataTable/ResizeableDataTable.scss | Removed redundant flex display property from CSS |
| src/components/QueryResultTable/QueryResultTable.tsx | Removed wrapper div with inline flex styles |
| src/components/Fullscreen/Fullscreen.tsx | Added proper resize event handling when entering/exiting fullscreen |
|
Stand redeployed |
Closes #2724
Closes #2720
Stand
Pages to check (URLs)
/clusters/cluster(plus tabs via/:activeTab)/tenant(with?clusterName=<name>in multi-cluster mode)/node/:id/:activeTab?/tenanttabs or/node/:id/...tabs depending on navigation/tablet/:id/vDisk?nodeId=<id>&vDiskId=<id>&database=<db>/pDisk?nodeId=<id>&pDiskId=<id>/storageGroup?groupId=<id>/tenant“Query” tab/tenant“Schema” tab/tenant“Query” → “Saved”/tenant“Query” → “History”/tenant“Diagnostics” → “Overview`/tenant“Diagnostics” → “Partitions`/tenant“Diagnostics” → “Top queries`/tenant“Diagnostics` respective tabs/clusters/tenant“Schema” tab/node/:id/threads/cluster/:activeTab=operations(cluster tabs)CI Results
Test Status:⚠️ FLAKY
📊 Full Report
Test Changes Summary ⏭️2
⏭️ Skipped Tests (2)
Bundle Size: ✅
Current: 85.39 MB | Main: 85.39 MB
Diff: 0.66 KB (-0.00%)
✅ Bundle size unchanged.
ℹ️ CI Information