Skip to content

Conversation

@astandrik
Copy link
Collaborator

@astandrik astandrik commented Sep 2, 2025

Closes #2724
Closes #2720

Stand

Pages to check (URLs)

  • Clusters list: /clusters
  • Single-cluster root (if singleClusterMode): /cluster (plus tabs via /:activeTab)
  • Tenants list: /tenant (with ?clusterName=<name> in multi-cluster mode)
  • Node details: /node/:id/:activeTab?
  • Tablets table pages:
    • Tablets page: embedded within /tenant tabs or /node/:id/... tabs depending on navigation
    • Individual tablet: /tablet/:id
  • Storage entities:
    • VDisk page: /vDisk?nodeId=<id>&vDiskId=<id>&database=<db>
    • PDisk page: /pDisk?nodeId=<id>&pDiskId=<id>
    • Storage group: /storageGroup?groupId=<id>
  • Query pages:
    • Query editor/result: under /tenant “Query” tab
    • Preview modal/table: invoked from schema browser under /tenant “Schema” tab
    • Saved queries: under /tenant “Query” → “Saved”
    • Queries history: under /tenant “Query” → “History”
  • Diagnostics (Tenant):
    • Overview (Top tables/groups, CPU/Memory/Network sections): under /tenant “Diagnostics” → “Overview`
    • Partitions: under /tenant “Diagnostics” → “Partitions`
    • Top queries with drawer: under /tenant “Diagnostics” → “Top queries`
    • Consumers/Configs/HotKeys/AsyncReplicationPaths: under /tenant “Diagnostics` respective tabs
  • Other tables:
    • Clusters page table content block: /clusters
    • Schema viewer table: under /tenant “Schema” tab
    • Node Threads: /node/:id/threads
    • Operations: usually under /cluster/:activeTab=operations (cluster tabs)

CI Results

Test Status: ⚠️ FLAKY

📊 Full Report

Total Passed Failed Flaky Skipped
378 372 0 4 2
Test Changes Summary ⏭️2

⏭️ Skipped Tests (2)

  1. Scroll to row, get shareable link, navigate to URL and verify row is scrolled into view (tenant/diagnostics/tabs/queries.test.ts)
  2. Copy result button copies to clipboard (tenant/queryEditor/queryEditor.test.ts)

Bundle Size: ✅

Current: 85.39 MB | Main: 85.39 MB
Diff: 0.66 KB (-0.00%)

✅ Bundle size unchanged.

ℹ️ CI Information
  • Test recordings for failed tests are available in the full report.
  • Bundle size is measured for the entire 'dist' directory.
  • 📊 indicates links to detailed reports.
  • 🔺 indicates increase, 🔽 decrease, and ✅ no change in bundle size.

This comment was marked as outdated.

artemmufazalov
artemmufazalov previously approved these changes Sep 3, 2025
@astandrik
Copy link
Collaborator Author

@Raubzeug reported some problem with full screen results - investigating

Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR fixes styling issues with query result tables by removing unnecessary flex display properties and improving fullscreen handling. The changes focus on resolving layout problems that were affecting table display in query results.

Key changes:

  • Removed manual resize event dispatching from ResultSetsViewer component
  • Simplified CSS flex display properties in ResizeableDataTable
  • Added proper fullscreen resize handling in the Fullscreen component

Reviewed Changes

Copilot reviewed 4 out of 4 changed files in this pull request and generated 1 comment.

File Description
src/containers/Tenant/Query/QueryResult/components/ResultSetsViewer/ResultSetsViewer.tsx Removed fullscreen state handling and manual resize event dispatching
src/components/ResizeableDataTable/ResizeableDataTable.scss Removed redundant flex display property from CSS
src/components/QueryResultTable/QueryResultTable.tsx Removed wrapper div with inline flex styles
src/components/Fullscreen/Fullscreen.tsx Added proper resize event handling when entering/exiting fullscreen

@astandrik
Copy link
Collaborator Author

Stand redeployed

@astandrik astandrik added this pull request to the merge queue Sep 3, 2025
Merged via the queue into main with commit 96913ac Sep 3, 2025
7 checks passed
@astandrik astandrik deleted the astandrik.fix-query-tables branch September 3, 2025 12:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Column width in results table varies on scroll Header in query results is not sticky

4 participants