fix(EntityStatus): fix buttons bg in selected table rows #2835
Conversation
|
|
||
| .entity-status { | ||
| --button-width: 28px; | ||
| --button-width: 24px; |
There was a problem hiding this comment.
With no paddings there less width is needed
| .entity-status { | ||
| --button-width: 28px; | ||
| --button-width: 24px; | ||
| --entity-status-height: 20px; |
There was a problem hiding this comment.
Without fixed height this element for some reason has extra 4px empty height. It was not visible because of 5px margin on link element. It can be fixed by display flex / inline-flex, but such display break buttons layout.
EntityStatus without fixed height and with display:block:
| .ydb-paginated-table__row:hover &, | ||
| .ydb-tree-view__item & { | ||
| width: min-content; | ||
| padding: var(--g-spacing-1); |
There was a problem hiding this comment.
Removed paddings to fix selected rows view
artemmufazalov
requested review from
Raubzeug,
adameat and
astandrik
as code owners
There was a problem hiding this comment.
Pull Request Overview
This PR fixes styling issues with button backgrounds in selected table rows for the EntityStatus component. The changes focus on improving the visual appearance and consistency of the EntityStatus component within table contexts.
- Adjusted button width and added height variables for better sizing consistency
- Removed padding from buttons container to prevent background bleeding
- Cleaned up margin styling for the status text
artemmufazalov
force-pushed
the
2751-entity-status
branch
from
342fb4c to
bc9602a
Compare
artemmufazalov
force-pushed
the
2751-entity-status
branch
from
bc9602a to
661c601
Compare
| renderName?: (name?: string) => React.ReactNode; | ||
| label?: string; | ||
| path?: string; | ||
| iconPath?: string; |
There was a problem hiding this comment.
Removed unused props to make component a little easier
Closes #2751
Stand: https://nda.ya.ru/t/jTA9G8kH7JVXA9
CI Results
Test Status:⚠️ FLAKY
📊 Full Report
Test Changes Summary ⏭️2
⏭️ Skipped Tests (2)
Bundle Size: 🔽
Current: 85.41 MB | Main: 85.42 MB
Diff: 7.72 KB (-0.01%)
✅ Bundle size decreased.
ℹ️ CI Information