-
Notifications
You must be signed in to change notification settings - Fork 17
feat: serverless database view #2836
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
| @@ -0,0 +1,9 @@ | |||
| .tenant-metrics-tabs_serverless { | |||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
bem notation doesn't allow modifiers as top level classes. Let's move this to MetricsTabs.scss
| type="container" | ||
| view={active ? 'outlined' : 'raised'} | ||
| > | ||
| <div className={b('legend-wrapper')}> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It seems only card content varies depend on variant, while wrapper is same. Lets make renderContent function?
|
|
||
| &__serverless-tag { | ||
| margin-left: var(--g-spacing-2); | ||
| padding: 2px var(--g-spacing-2); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
2px = var(--g-spacing-half)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
now using Label component
| "context_capacity-usage": "{{value}} of {{capacity}}", | ||
| "network-stats-unavailable.title": "Network Statistics Unavailable", | ||
| "network-stats-unavailable.description": "Network ping and clock skew statistics require a newer backend version. Please upgrade your YDB installation to access these features." | ||
| "network-stats-unavailable.description": "Network ping and clock skew statistics require a newer backend version. Please upgrade your YDB installation to access these features.", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For keysets naming let's stick to https://nda.ya.ru/t/4A_EEYWW7JXQco
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
fixed
|
bugbot run |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
✅ Bugbot reviewed your changes and found no bugs!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR implements a dedicated serverless database view that provides a simplified interface for serverless databases by hiding resource metrics that don't apply to auto-scaling environments and adding visual indicators for serverless mode.
- Adds serverless-specific UI components and layouts for tenant overview pages
- Filters available diagnostic tabs for serverless databases to remove inapplicable sections
- Implements visual serverless tags and placeholder tabs for hidden metrics
Reviewed Changes
Copilot reviewed 17 out of 17 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
src/utils/constants.ts |
Adds non-breaking space constant for UI formatting |
src/store/reducers/tenant/tenant.ts |
Extends tenant base info hook to include database type information |
src/containers/Tenant/Diagnostics/i18n/ |
Creates new i18n module for diagnostics with "No data" translation |
src/containers/Tenant/Diagnostics/TenantOverview/i18n/en.json |
Adds serverless-specific translation keys and restructures network stats messages |
src/containers/Tenant/Diagnostics/TenantOverview/TenantStorage/TenantStorage.tsx |
Implements simplified storage view for serverless databases |
src/containers/Tenant/Diagnostics/TenantOverview/TenantOverview.tsx |
Adds serverless tag UI and adjusts active tab logic for serverless mode |
src/containers/Tenant/Diagnostics/TenantOverview/TenantOverview.scss |
Adds styling for serverless tag component |
src/containers/Tenant/Diagnostics/TenantOverview/TenantCpu/TenantCpu.tsx |
Conditionally hides resource charts for serverless databases |
src/containers/Tenant/Diagnostics/TenantOverview/TabCard/TabCard.tsx |
Refactors tab cards to support serverless display mode |
src/containers/Tenant/Diagnostics/TenantOverview/MetricsTabs/ |
Creates modular tab components for different database types |
src/containers/Tenant/Diagnostics/DiagnosticsPages.ts |
Updates page filtering logic to handle serverless database constraints |
src/containers/Tenant/Diagnostics/Diagnostics.tsx |
Integrates serverless database type into diagnostics page rendering |
src/containers/Tenant/Diagnostics/TenantOverview/MetricsTabs/CommonMetricsTabs.tsx
Show resolved
Hide resolved
|
fixed |
Closes #2753
Stand
CI Results
Test Status:⚠️ FLAKY
📊 Full Report
Test Changes Summary ⏭️2
⏭️ Skipped Tests (2)
Bundle Size: 🔺
Current: 85.41 MB | Main: 85.39 MB
Diff: +0.02 MB (0.02%)
ℹ️ CI Information