Skip to content

Conversation

@astandrik
Copy link
Collaborator

@astandrik astandrik commented Sep 4, 2025

Closes #2753

Stand

CI Results

Test Status: ⚠️ FLAKY

📊 Full Report

Total Passed Failed Flaky Skipped
378 373 0 3 2
Test Changes Summary ⏭️2

⏭️ Skipped Tests (2)

  1. Scroll to row, get shareable link, navigate to URL and verify row is scrolled into view (tenant/diagnostics/tabs/queries.test.ts)
  2. Copy result button copies to clipboard (tenant/queryEditor/queryEditor.test.ts)

Bundle Size: 🔺

Current: 85.41 MB | Main: 85.39 MB
Diff: +0.02 MB (0.02%)

⚠️ Bundle size increased. Please review.

ℹ️ CI Information
  • Test recordings for failed tests are available in the full report.
  • Bundle size is measured for the entire 'dist' directory.
  • 📊 indicates links to detailed reports.
  • 🔺 indicates increase, 🔽 decrease, and ✅ no change in bundle size.

@astandrik astandrik requested a review from Copilot September 4, 2025 13:18

This comment was marked as outdated.

@astandrik astandrik requested a review from Copilot September 4, 2025 14:02
cursor[bot]

This comment was marked as outdated.

This comment was marked as outdated.

@ydb-platform ydb-platform deleted a comment from claude bot Sep 4, 2025
@astandrik astandrik requested a review from Copilot September 4, 2025 17:13

This comment was marked as outdated.

@astandrik astandrik marked this pull request as ready for review September 4, 2025 17:19
@@ -0,0 +1,9 @@
.tenant-metrics-tabs_serverless {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

bem notation doesn't allow modifiers as top level classes. Let's move this to MetricsTabs.scss

type="container"
view={active ? 'outlined' : 'raised'}
>
<div className={b('legend-wrapper')}>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It seems only card content varies depend on variant, while wrapper is same. Lets make renderContent function?


&__serverless-tag {
margin-left: var(--g-spacing-2);
padding: 2px var(--g-spacing-2);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

2px = var(--g-spacing-half)

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

now using Label component

"context_capacity-usage": "{{value}} of {{capacity}}",
"network-stats-unavailable.title": "Network Statistics Unavailable",
"network-stats-unavailable.description": "Network ping and clock skew statistics require a newer backend version. Please upgrade your YDB installation to access these features."
"network-stats-unavailable.description": "Network ping and clock skew statistics require a newer backend version. Please upgrade your YDB installation to access these features.",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For keysets naming let's stick to https://nda.ya.ru/t/4A_EEYWW7JXQco

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fixed

@astandrik astandrik requested a review from Copilot September 5, 2025 10:18

This comment was marked as outdated.

@astandrik astandrik requested review from Copilot September 5, 2025 11:06
@astandrik
Copy link
Collaborator Author

bugbot run
/claude_review

This comment was marked as outdated.

This comment was marked as outdated.

Copy link

@cursor cursor bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ Bugbot reviewed your changes and found no bugs!


@ydb-platform ydb-platform deleted a comment from claude bot Sep 5, 2025
@astandrik astandrik requested a review from Copilot September 5, 2025 13:10
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR implements a dedicated serverless database view that provides a simplified interface for serverless databases by hiding resource metrics that don't apply to auto-scaling environments and adding visual indicators for serverless mode.

  • Adds serverless-specific UI components and layouts for tenant overview pages
  • Filters available diagnostic tabs for serverless databases to remove inapplicable sections
  • Implements visual serverless tags and placeholder tabs for hidden metrics

Reviewed Changes

Copilot reviewed 17 out of 17 changed files in this pull request and generated 1 comment.

Show a summary per file
File Description
src/utils/constants.ts Adds non-breaking space constant for UI formatting
src/store/reducers/tenant/tenant.ts Extends tenant base info hook to include database type information
src/containers/Tenant/Diagnostics/i18n/ Creates new i18n module for diagnostics with "No data" translation
src/containers/Tenant/Diagnostics/TenantOverview/i18n/en.json Adds serverless-specific translation keys and restructures network stats messages
src/containers/Tenant/Diagnostics/TenantOverview/TenantStorage/TenantStorage.tsx Implements simplified storage view for serverless databases
src/containers/Tenant/Diagnostics/TenantOverview/TenantOverview.tsx Adds serverless tag UI and adjusts active tab logic for serverless mode
src/containers/Tenant/Diagnostics/TenantOverview/TenantOverview.scss Adds styling for serverless tag component
src/containers/Tenant/Diagnostics/TenantOverview/TenantCpu/TenantCpu.tsx Conditionally hides resource charts for serverless databases
src/containers/Tenant/Diagnostics/TenantOverview/TabCard/TabCard.tsx Refactors tab cards to support serverless display mode
src/containers/Tenant/Diagnostics/TenantOverview/MetricsTabs/ Creates modular tab components for different database types
src/containers/Tenant/Diagnostics/DiagnosticsPages.ts Updates page filtering logic to handle serverless database constraints
src/containers/Tenant/Diagnostics/Diagnostics.tsx Integrates serverless database type into diagnostics page rendering

@astandrik astandrik requested a review from Raubzeug September 5, 2025 13:15
@astandrik
Copy link
Collaborator Author

fixed
Stand redeployed

@astandrik astandrik added this pull request to the merge queue Sep 5, 2025
Merged via the queue into main with commit 5654ed0 Sep 5, 2025
7 checks passed
@astandrik astandrik deleted the astandrik.2753 branch September 5, 2025 15:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Serverless Database view

3 participants