Skip to content

fix(Tablets): update filter #2887

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Sep 16, 2025
Merged

fix(Tablets): update filter #2887

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
35af584
fix(Tablets): update filter
Raubzeug Sep 16, 2025
e1734c8
fix: review
Raubzeug Sep 16, 2025
135c25a
fix: typecheck
Raubzeug Sep 16, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion src/containers/Tablets/Tablets.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,7 +34,9 @@ export function Tablets({
const [autoRefreshInterval] = useAutoRefreshInterval();

let params: TabletsApiRequestParams = {};
const filter = onlyActive ? `(State!=Dead)` : undefined;
const filter = onlyActive
? `(State=[Created,ResolveStateStorage,Candidate,BlockBlobStorage,RebuildGraph,WriteZeroEntry,Restored,Discover,Lock,Active,ResolveLeader,Terminating])`
Copy link
Member

@artemmufazalov artemmufazalov Sep 16, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Number of not active statuses is much less than active. Is it possible to set filter as State!=[Dead,Deleted,Stopped]? Found the answer in the ticket

Also it will be good to ensure proper strings with types:

const activeStatuses: ETabletState = [
    'Created',
    'ResolveStateStorage',
    'Candidate',
    'BlockBlobStorage',
    'RebuildGraph',
    'WriteZeroEntry',
    'Restored',
    'Discover',
    'Lock',
    'Active',
    'ResolveLeader',
    'Terminating'
]

const filter = onlyActive ? `(State=${activeStatuses.join(',')}` : undefined

: undefined;

const schemaPathParam = React.useMemo(() => {
if (!isNil(path) && !isNil(databaseFullPath)) {
Expand Down
Loading