-
Notifications
You must be signed in to change notification settings - Fork 17
feat: renderMonitoring to diagnostics #3032
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from 2 commits
Commits
Show all changes
7 commits
Select commit
Hold shift + click to select a range
7068373
feat: option to insert additional diagnostics tab
astandrik 7151974
fix: use render pattern
astandrik f6ff486
fix: better code and buttons
astandrik ed3b31c
fix: remove rooignore
astandrik 5dcff7a
fix: review fix
astandrik 463aa07
fix: review fixes
astandrik 0be3f53
fix: review fix
astandrik File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Some comments aren't visible on the classic Files Changed page.
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,34 @@ | ||
| # See https://help.github.com/articles/ignoring-files/ for more about ignoring files. | ||
|
|
||
| # dependencies | ||
| /node_modules | ||
| /.pnp | ||
| .pnp.js | ||
|
|
||
| # testing | ||
| /coverage | ||
| playwright-artifacts | ||
|
|
||
| # production | ||
| /build | ||
| /dist | ||
| *.zip | ||
|
|
||
| # misc | ||
| .idea | ||
| .DS_Store | ||
| .env.local | ||
| .env.development.local | ||
| .env.test.local | ||
| .env.production.local | ||
| .vscode | ||
| .cursor | ||
|
|
||
| npm-debug.log* | ||
| yarn-debug.log* | ||
| yarn-error.log* | ||
|
|
||
| .env | ||
|
|
||
|
|
||
| embedded-ui.tar.bz2 | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -7,6 +7,7 @@ import {TENANT_DIAGNOSTICS_TABS_IDS} from '../../../store/reducers/tenant/consta | |
| import type {TenantDiagnosticsTab} from '../../../store/reducers/tenant/types'; | ||
| import {EPathSubType, EPathType} from '../../../types/api/schema'; | ||
| import type {ETenantType} from '../../../types/api/tenant'; | ||
| import {uiFactory} from '../../../uiFactory/uiFactory'; | ||
| import type {TenantQuery} from '../TenantPages'; | ||
| import {TenantTabsGroups} from '../TenantPages'; | ||
| import {isDatabaseEntityType, isTopicEntityType} from '../utils/schema'; | ||
|
|
@@ -110,6 +111,11 @@ const operations = { | |
| title: 'Operations', | ||
| }; | ||
|
|
||
| const monitoring = { | ||
| id: TENANT_DIAGNOSTICS_TABS_IDS.monitoring, | ||
| title: 'Monitoring', | ||
| }; | ||
|
|
||
| const ASYNC_REPLICATION_PAGES = [overview, tablets, describe, access]; | ||
|
|
||
| const TRANSFER_PAGES = [overview, tablets, describe, access]; | ||
|
|
@@ -233,7 +239,14 @@ export const getPagesByType = ( | |
| const dbContext = isDatabaseEntityType(type) || options?.isTopLevel; | ||
| const seeded = dbContext ? getDatabasePages(options?.databaseType) : base; | ||
|
|
||
| return applyFilters(seeded, type, options); | ||
| const result = applyFilters(seeded, type, options); | ||
|
|
||
| // Add monitoring tab as second tab if renderMonitoring is available | ||
| if (uiFactory.renderMonitoring) { | ||
|
||
| result.splice(1, 0, monitoring); | ||
| } | ||
astandrik marked this conversation as resolved.
Outdated
Show resolved
Hide resolved
|
||
|
|
||
| return result; | ||
| }; | ||
|
|
||
| export const useDiagnosticsPageLinkGetter = () => { | ||
|
|
||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.