Merge pull request #1437 from ydb-platform/golangci-lint

switched version of golangci-lint from v1.55.2 to 1.60.3

Author: asmyasnikov

.github/workflows/lint.yml

@@ -7,7 +7,7 @@ on:
   pull_request:
   workflow_dispatch:
 env:
-  GOLANGCI_LINT_VERSION: v1.55.2
+  GOLANGCI_LINT_VERSION: v1.60.3
 jobs:
   golangci:
     name: golangci-lint

.golangci.yml

@@ -10,14 +10,6 @@ run:
   #build-tags:
   #  - mytag
 
-  # which dirs to skip: they won't be analyzed;
-  # can use regexp here: generated.*, regexp is applied on full path;
-  # default value is empty list, but next dirs are always skipped independently
-  # from this option's value:
-  #   	vendor$, third_party$, testdata$, examples$, Godeps$, builtin$
-  # skip-dirs:
-  skip-dirs-use-default: false
-
   # which files to skip: they will be analyzed, but issues from them
   # won't be reported. Default value is empty list, but there is
   # no need to include all autogenerated files, we confidently recognize
@@ -30,7 +22,7 @@ run:
 # output configuration options
 output:
   # colored-line-number|line-number|json|tab|checkstyle, default is "colored-line-number"
-  format: colored-line-number
+  formats: colored-line-number
 
   # print lines of code with issue, default is true
   print-issued-lines: true
@@ -51,10 +43,7 @@ linters-settings:
     check-blank: false
   govet:
     # report about shadowed variables
-    check-shadowing: true
-  golint:
-    # minimal confidence for issues, default is 0.8
-    min-confidence: 0.8
+    shadow: true
   gofmt:
     # simplify code: gofmt with `-s` option, true by default
     simplify: true
@@ -222,22 +211,28 @@ linters:
     - cyclop
     - depguard
     - dupl
+    - err113
     - exhaustive
-    - exhaustivestruct
     - exhaustruct
+    - fatcontext
     - forbidigo
     - gochecknoglobals
     - gocognit
+    - gocritic
     - godot
-    - goerr113
-    - golint
+    - gomnd
+    - gosec
     - interfacebloat
+    - intrange
     - ireturn
     - maintidx
+    - mnd
     - nonamedreturns
     - paralleltest
-    - structcheck
+    - perfsprint
+    - predeclared
     - testableexamples
+    - testifylint
     - testpackage
     - thelper
     - varnamelen
@@ -267,6 +262,11 @@ issues:
   # Default value for this option is true.
   exclude-use-default: true
 
+  # Enables exclude of directories:
+  # - vendor$, third_party$, testdata$, examples$, Godeps$, builtin$
+  # Default: true
+  exclude-dirs-use-default: false
+
   # Maximum count of issues with the same text. Set to 0 to disable. Default is 3.
   max-same-issues: 0
 
@@ -302,7 +302,6 @@ issues:
       text: "ydb.Connection is deprecated"
     - path: examples
       linters:
-        - gomnd
         - funlen
     - path: tests
       linters:

examples/go.mod

@@ -1,6 +1,6 @@
 module examples
 
-go 1.22
+go 1.23
 
 require (
 	github.com/golang-jwt/jwt/v4 v4.5.0

examples/ttl_readtable/series.go

@@ -98,7 +98,7 @@ func deleteExpiredRange(ctx context.Context, c table.Client, prefix string, time
 	// As single key range usually represents a single shard, so we batch deletions here
 	// without introducing distributed transactions.
 	var (
-		docIds []uint64
+		docIDs []uint64
 		docID  uint64
 		ts     uint64
 	)
@@ -113,20 +113,20 @@ func deleteExpiredRange(ctx context.Context, c table.Client, prefix string, time
 			}
 
 			if ts <= timestamp {
-				docIds = append(docIds, docID)
+				docIDs = append(docIDs, docID)
 			}
-			if len(docIds) >= deleteBatchSize {
-				if err := deleteExpiredDocuments(ctx, c, prefix, docIds, timestamp); err != nil {
+			if len(docIDs) >= deleteBatchSize {
+				if err := deleteExpiredDocuments(ctx, c, prefix, docIDs, timestamp); err != nil {
 					return err
 				}
-				docIds = []uint64{}
+				docIDs = []uint64{}
 			}
 		}
-		if len(docIds) > 0 {
-			if err := deleteExpiredDocuments(ctx, c, prefix, docIds, timestamp); err != nil {
+		if len(docIDs) > 0 {
+			if err := deleteExpiredDocuments(ctx, c, prefix, docIDs, timestamp); err != nil {
 				return err
 			}
-			docIds = []uint64{}
+			docIDs = []uint64{}
 		}
 	}
 

internal/balancer/connections_state_test.go

@@ -232,7 +232,7 @@ func TestSelectRandomConnection(t *testing.T) {
 			case "2":
 				second++
 			default:
-				t.Errorf(c.Endpoint().Address())
+				t.Error(c.Endpoint().Address())
 			}
 		}
 		require.Equal(t, 100, first+second)

internal/conn/conn.go

@@ -126,7 +126,6 @@ func (c *conn) park(ctx context.Context) (err error) {
 	}
 
 	err = c.close(ctx)
-
 	if err != nil {
 		return xerrors.WithStackTrace(err)
 	}

internal/conn/grpc_client_stream.go

@@ -52,7 +52,6 @@ func (s *grpcClientStream) CloseSend() (err error) {
 	defer stop()
 
 	err = s.stream.CloseSend()
-
 	if err != nil {
 		if xerrors.IsContextError(err) {
 			return xerrors.WithStackTrace(err)
@@ -88,7 +87,6 @@ func (s *grpcClientStream) SendMsg(m interface{}) (err error) {
 	defer stop()
 
 	err = s.stream.SendMsg(m)
-
 	if err != nil {
 		if xerrors.IsContextError(err) {
 			return xerrors.WithStackTrace(err)
@@ -144,7 +142,6 @@ func (s *grpcClientStream) RecvMsg(m interface{}) (err error) { //nolint:funlen
 	defer stop()
 
 	err = s.stream.RecvMsg(m)
-
 	if err != nil {
 		if xerrors.Is(err, io.EOF) {
 			return io.EOF

internal/credentials/oauth2.go

@@ -451,7 +451,6 @@ func GetSupportedOauth2TokenExchangeJwtAlgorithms() []string {
 	return algs
 }
 
-//nolint:musttag
 type stringOrArrayConfig struct {
 	Values []string
 }

internal/query/execute_query.go

@@ -176,7 +176,7 @@ func readMaterializedResultSet(ctx context.Context, r *streamResult) (_ *materia
 
 	var rows []query.Row
 	for {
-		row, err := rs.nextRow(ctx) //nolint:govet
+		row, err := rs.nextRow(ctx)
 		if err != nil {
 			if xerrors.Is(err, io.EOF) {
 				break

internal/query/result_set_range_test.go

@@ -521,6 +521,7 @@ func TestResultSetRange(t *testing.T) {
 	})
 	t.Run("CanceledContext", func(t *testing.T) {
 		childCtx, cancel := context.WithCancel(xtest.Context(t))
+		defer cancel()
 		stream := NewMockQueryService_ExecuteQueryClient(ctrl)
 		stream.EXPECT().Recv().Return(&Ydb_Query.ExecuteQueryResponsePart{
 			Status:         Ydb.StatusIds_SUCCESS,