Skip to content

Commit aec0f59

Browse files
authored
Merge pull request #696 from ydb-platform/drop-with-block
removed WithBlock() from defaults
2 parents e4bf5d6 + 982b6cc commit aec0f59

File tree

2 files changed

+0
-4
lines changed

2 files changed

+0
-4
lines changed

CHANGELOG.md

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -8,7 +8,6 @@
88
* Fixed code -1 of retryable error if wrapped error with code
99
* Added `ydb.MustOpen` and `ydb.MustConnector` helpers
1010
* Fixed `internal/xerrors.Transport` error wrapping for case when given error is not transport error
11-
* Added `grpc.WithBlock()` dial option to defaults
1211
* Added grpc and operation codes to errors string description
1312
* Extend `scheme.Client` interface with method `Database`
1413
* Removed `driver.ResultNoRows` in `internal/xsql`

config/defaults.go

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -31,9 +31,6 @@ var (
3131

3232
func defaultGrpcOptions(t trace.Driver, secure bool, tlsConfig *tls.Config) (opts []grpc.DialOption) {
3333
opts = append(opts,
34-
// Block call `DialContext` for dial done or fail
35-
// For exclude dial errors on `Invoke` and `NewStream` steps
36-
grpc.WithBlock(),
3734
// keep-aliving all connections
3835
grpc.WithKeepaliveParams(
3936
DefaultGrpcConnectionPolicy,

0 commit comments

Comments
 (0)