Skip to content

Commit bf0b0bf

Browse files
docs(slo): add attempts metric to README.md
1 parent 9558374 commit bf0b0bf

File tree

2 files changed

+4
-1
lines changed

2 files changed

+4
-1
lines changed

tests/slo/README.md

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -123,6 +123,7 @@ Primary key: `("hash", "id")`
123123
- `not_oks` - amount of not OK requests
124124
- `inflight` - amount of requests in flight
125125
- `latency` - summary of latencies in ms
126+
- `attempts` - summary of amount for request
126127

127128
> You must reset metrics to keep them `0` in prometheus and grafana before beginning and after ending of jobs
128129
@@ -140,6 +141,8 @@ func (m *Metrics) Reset() error {
140141

141142
m.latencies.Reset()
142143

144+
m.attempts.Reset()
145+
143146
return m.Push()
144147
}
145148
```

tests/slo/internal/metrics/metrics.go

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -76,7 +76,7 @@ func New(logger *zap.Logger, url, label string) (*Metrics, error) {
7676
m.attempts = prometheus.NewHistogramVec(
7777
prometheus.HistogramOpts{
7878
Name: "attempts",
79-
Help: "amount of retries for request",
79+
Help: "summary of amount for request",
8080
Buckets: prometheus.LinearBuckets(1, 1, 10),
8181
},
8282
[]string{"status", "jobName"},

0 commit comments

Comments
 (0)