Skip to content

Commit ebc4907

Browse files
committed
fix review issues
1 parent ee04de8 commit ebc4907

File tree

3 files changed

+14
-13
lines changed

3 files changed

+14
-13
lines changed

spans/discovery.go

Lines changed: 11 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,8 @@
11
package spans
22

33
import (
4+
"fmt"
5+
46
"github.com/ydb-platform/ydb-go-sdk/v3/internal/kv"
57
"github.com/ydb-platform/ydb-go-sdk/v3/trace"
68
)
@@ -17,15 +19,16 @@ func discovery(adapter Adapter) (t trace.Discovery) {
1719
)
1820

1921
return func(info trace.DiscoveryDiscoverDoneInfo) {
20-
endpoints := make([]string, len(info.Endpoints))
21-
for i, e := range info.Endpoints {
22-
endpoints[i] = e.String()
22+
if info.Error != nil {
23+
start.Error(info.Error)
24+
} else {
25+
endpoints := make([]string, len(info.Endpoints))
26+
for i, e := range info.Endpoints {
27+
endpoints[i] = e.String()
28+
}
29+
start.Log(fmt.Sprintf("endpoints=%v", endpoints))
2330
}
24-
finish(
25-
start,
26-
info.Error,
27-
kv.Strings("endpoints", endpoints),
28-
)
31+
start.End()
2932
}
3033
}
3134

spans/driver.go

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -298,11 +298,11 @@ func driver(adapter Adapter) trace.Driver { //nolint:gocyclo,funlen
298298
for i, e := range info.Dropped {
299299
dropped[i] = e.String()
300300
}
301+
start.Log(fmt.Sprintf("endpoints=%v", endpoints))
302+
start.Log(fmt.Sprintf("added=%v", added))
303+
start.Log(fmt.Sprintf("dropped=%v", dropped))
301304
start.End(
302305
kv.String("local_dc", info.LocalDC),
303-
kv.Strings("endpoints", endpoints),
304-
kv.Strings("added", added),
305-
kv.Strings("dropped", dropped),
306306
)
307307
}
308308
},

spans/scripting.go

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -14,7 +14,6 @@ func scripting(adapter Adapter) (t trace.Scripting) {
1414
info.Context,
1515
info.Call.FunctionID(),
1616
kv.String("query", info.Query),
17-
kv.String("params", safeStringer(info.Parameters)),
1817
)
1918

2019
return func(info trace.ScriptingExecuteDoneInfo) {
@@ -47,7 +46,6 @@ func scripting(adapter Adapter) (t trace.Scripting) {
4746
info.Context,
4847
info.Call.FunctionID(),
4948
kv.String("query", info.Query),
50-
kv.String("params", safeStringer(info.Parameters)),
5149
)
5250

5351
return func(

0 commit comments

Comments
 (0)