Fix session leak when context canceled during async creation#1982
Draft
Fix session leak when context canceled during async creation#1982
Conversation
When context is canceled while a session is being created, the session was being added to the pool index but then attempted to be put back via putItem(). This caused issues because: 1. The session would be in the index but not properly tracked 2. In some cases it could exceed pool limits The fix removes the session from the index and closes it directly when the caller has canceled, rather than trying to put it back in the pool. Added test to validate the fix handles both race conditions: - Item created before context check (item returned to caller) - Context canceled before item creation (item closed, not added to pool) Co-authored-by: asmyasnikov <14202262+asmyasnikov@users.noreply.github.com>
Use separate closeCtx variable instead of reassigning createCtx to avoid potential resource leaks from not calling the previous context's cancel function. Co-authored-by: asmyasnikov <14202262+asmyasnikov@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Fix session leak when context is canceled early
Fix session leak when context canceled during async creation
Dec 16, 2025
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #1982 +/- ##
=======================================
Coverage 74.14% 74.14%
=======================================
Files 395 395
Lines 34598 34606 +8
=======================================
+ Hits 25654 25660 +6
+ Misses 7825 7820 -5
- Partials 1119 1126 +7
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
summaryInferred base version: v3.123.1 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When context is canceled while a session is being created asynchronously, the session was added to the pool index but never properly cleaned up, causing the pool to grow beyond configured limits.
Root Cause
In
makeAsyncCreateItemFunc, the background goroutine adds newly created items top.indeximmediately after creation. When the caller's context is canceled before receiving the item:p.indexputItem()on an item the caller never receivedcreateInProgressis decremented, allowing limit violationsChanges
<-donecase, remove item from index and close it directly instead of callingputItem()ContextCanceledDuringCreatetest covering both race conditions:Original prompt
💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.