Skip to content

Session pool nodeid limit#2005

Open
qrort wants to merge 2 commits intomasterfrom
session-pool-nodeid-limit
Open

Session pool nodeid limit#2005
qrort wants to merge 2 commits intomasterfrom
session-pool-nodeid-limit

Conversation

@qrort
Copy link
Collaborator

@qrort qrort commented Jan 20, 2026

Pull request type

Please check the type of change your PR introduces:

  • Bugfix
  • Feature
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • Documentation content changes
  • Other (please describe):

What is the current behavior?

Issue Number: N/A

What is the new behavior?

Other information

@github-actions
Copy link

github.com/ydb-platform/ydb-go-sdk/v3

compatible changes

WithSessionPoolNodeLimit: added

summary

Inferred base version: v3.125.1
Suggested version: v3.126.0

@codecov-commenter
Copy link

codecov-commenter commented Jan 20, 2026

Codecov Report

❌ Patch coverage is 50.00000% with 24 lines in your changes missing coverage. Please review.
✅ Project coverage is 55.13%. Comparing base (fed0e3c) to head (7095188).

Files with missing lines Patch % Lines
internal/pool/pool.go 60.00% 8 Missing and 2 partials ⚠️
internal/query/config/options.go 0.00% 4 Missing ⚠️
internal/table/config/config.go 42.85% 4 Missing ⚠️
options.go 20.00% 4 Missing ⚠️
internal/endpoint/context.go 0.00% 2 Missing ⚠️

❗ There is a different number of reports uploaded between BASE (fed0e3c) and HEAD (7095188). Click for more details.

HEAD has 508 uploads less than BASE
Flag BASE (fed0e3c) HEAD (7095188)
unit 72 0
go-1.21.x 71 3
ubuntu 103 6
go-1.25.x 80 3
macOS 24 0
windows 24 0
ydb-latest 23 2
integration 69 6
ydb-24.4 22 2
experiment 10 0
ydb-nightly 10 0
ydb-25.2 24 2
Additional details and impacted files
@@             Coverage Diff             @@
##           master    #2005       +/-   ##
===========================================
- Coverage   74.20%   55.13%   -19.07%     
===========================================
  Files         397      384       -13     
  Lines       34743    33360     -1383     
===========================================
- Hits        25781    18394     -7387     
- Misses       7848    13665     +5817     
- Partials     1114     1301      +187     
Flag Coverage Δ
experiment ?
go-1.21.x 55.10% <50.00%> (-17.97%) ⬇️
go-1.25.x 55.12% <50.00%> (-19.07%) ⬇️
integration 55.13% <50.00%> (-0.37%) ⬇️
macOS ?
ubuntu 55.13% <50.00%> (-19.07%) ⬇️
unit ?
windows ?
ydb-24.4 54.51% <50.00%> (-0.17%) ⬇️
ydb-25.2 55.06% <50.00%> (-0.36%) ⬇️
ydb-latest 54.83% <50.00%> (-0.38%) ⬇️
ydb-nightly ?

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants