Skip to content

Increase default closing timeouts #318

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 24, 2024
Merged

Increase default closing timeouts #318

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion core/src/main/java/tech/ydb/core/impl/YdbSchedulerFactory.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,12 +9,14 @@
import org.slf4j.Logger;
import org.slf4j.LoggerFactory;


/**
*
* @author Aleksandr Gorshenin
*/
public class YdbSchedulerFactory {
private static final long WAIT_FOR_SHUTDOWN_MS = 1000;
/** Scheduler waits for closing of channels so this timeout must be greater that GrpcChannel.WAIT_FOR_CLOSING_MS */
private static final long WAIT_FOR_SHUTDOWN_MS = 2 * 5000;

private static final Logger logger = LoggerFactory.getLogger(YdbSchedulerFactory.class);

Expand Down
3 changes: 2 additions & 1 deletion core/src/main/java/tech/ydb/core/impl/pool/GrpcChannel.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,8 @@
* @author Nikolay Perfilov
*/
public class GrpcChannel {
private static final long WAIT_FOR_CLOSING_MS = 1000;
/* Channel shutdown waits for finish of active grpc calls, so there must be enough time to complete them all */
private static final long WAIT_FOR_CLOSING_MS = 5000;
private static final Logger logger = LoggerFactory.getLogger(GrpcChannel.class);

private final EndpointRecord endpoint;
Expand Down