Skip to content

Conversation

@alex268
Copy link
Member

@alex268 alex268 commented Sep 24, 2024

No description provided.

@alex268 alex268 requested a review from pnv1 September 24, 2024 11:59
@codecov-commenter
Copy link

Codecov Report

Attention: Patch coverage is 50.00000% with 37 lines in your changes missing coverage. Please review.

Project coverage is 47.39%. Comparing base (9227ada) to head (f79ec33).

Files with missing lines Patch % Lines
...a/tech/ydb/core/impl/pool/NettyChannelFactory.java 0.00% 8 Missing ⚠️
.../tech/ydb/core/impl/pool/ChannelFactoryLoader.java 50.00% 5 Missing and 2 partials ⚠️
...src/main/java/tech/ydb/core/utils/FutureTools.java 0.00% 7 Missing ⚠️
...src/main/java/tech/ydb/core/impl/YdbDiscovery.java 76.47% 4 Missing ⚠️
.../java/tech/ydb/core/grpc/GrpcTransportBuilder.java 25.00% 2 Missing and 1 partial ⚠️
...main/java/tech/ydb/core/impl/pool/GrpcChannel.java 70.00% 3 Missing ⚠️
...java/tech/ydb/query/tools/SessionRetryContext.java 0.00% 2 Missing ⚠️
.../main/java/tech/ydb/table/SessionRetryContext.java 50.00% 0 Missing and 2 partials ⚠️
...src/main/java/tech/ydb/query/impl/SessionPool.java 0.00% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##             master     #319      +/-   ##
============================================
+ Coverage     47.36%   47.39%   +0.03%     
- Complexity     1727     1729       +2     
============================================
  Files           304      305       +1     
  Lines         12350    12362      +12     
  Branches       1229     1233       +4     
============================================
+ Hits           5849     5859      +10     
+ Misses         6046     6045       -1     
- Partials        455      458       +3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@alex268 alex268 merged commit fef5bde into ydb-platform:master Sep 24, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants