Skip to content

Conversation

@alex268
Copy link
Member

@alex268 alex268 commented Oct 3, 2024

Resolve UUID creating methods inconsistency
ydb-platform/ydb#9799

Fixes #326

@alex268 alex268 changed the title Deprecated internal methods for UUID type Deprecate direct usage of internal method for UUID creating Oct 3, 2024
@alex268 alex268 requested review from SammyVimes and pnv1 October 3, 2024 09:53
@codecov-commenter
Copy link

codecov-commenter commented Oct 3, 2024

Codecov Report

Attention: Patch coverage is 78.57143% with 12 lines in your changes missing coverage. Please review.

Project coverage is 47.53%. Comparing base (871ddc1) to head (8b36eec).
Report is 3 commits behind head on master.

Files with missing lines Patch % Lines
...n/java/tech/ydb/table/values/proto/ProtoValue.java 79.24% 7 Missing and 4 partials ⚠️
...ain/java/tech/ydb/table/values/PrimitiveValue.java 66.66% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##             master     #324      +/-   ##
============================================
+ Coverage     47.41%   47.53%   +0.11%     
- Complexity     1739     1749      +10     
============================================
  Files           305      305              
  Lines         12381    12388       +7     
  Branches       1235     1236       +1     
============================================
+ Hits           5871     5889      +18     
+ Misses         6049     6038      -11     
  Partials        461      461              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@alex268 alex268 requested a review from rekby October 4, 2024 14:55
@alex268 alex268 changed the title Deprecate direct usage of internal method for UUID creating Update methods to create and serialize UUIDs Oct 7, 2024
@alex268 alex268 merged commit 7722d88 into ydb-platform:master Oct 14, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Ensure correct work UUID

3 participants