Skip to content

Remove "This shouldn't happen" from topic reader logs where it can actually happen #349

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Dec 5, 2024
Merged

Remove "This shouldn't happen" from topic reader logs where it can actually happen #349

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 4 additions & 5 deletions topic/src/main/java/tech/ydb/topic/read/impl/ReaderImpl.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -456,9 +456,8 @@ private void onReadResponse(YdbTopic.StreamReadMessage.ReadResponse readResponse
CompletableFuture<Void> readFuture = partitionSession.addBatches(data.getBatchesList());
batchReadFutures.add(readFuture);
} else {
logger.error("[{}] Received PartitionData for unknown(closed?) PartitionSessionId={}. " +
"This shouldn't happen",
fullId, partitionId);
logger.info("[{}] Received PartitionData for unknown(most likely already closed) " +
"PartitionSessionId={}", fullId, partitionId);
}
});
CompletableFuture.allOf(batchReadFutures.toArray(new CompletableFuture<?>[0]))
Expand Down Expand Up @@ -491,8 +490,8 @@ protected void onCommitOffsetResponse(YdbTopic.StreamReadMessage.CommitOffsetRes
handleCommitResponse(partitionCommittedOffset.getCommittedOffset(),
partitionSession.getSessionInfo());
} else {
logger.error("[{}] Received CommitOffsetResponse for unknown (closed?) partition session with " +
"id={}. This shouldn't happen", fullId,
logger.info("[{}] Received CommitOffsetResponse for unknown (most likely already closed) " +
"partition session with id={}", fullId,
partitionCommittedOffset.getPartitionSessionId());
}
}
Expand Down
Loading