Skip to content

Conversation

@alex268
Copy link
Member

@alex268 alex268 commented Feb 10, 2025

fixes #366

@alex268 alex268 requested a review from pnv1 February 10, 2025 11:36
@codecov-commenter
Copy link

Codecov Report

Attention: Patch coverage is 69.64286% with 34 lines in your changes missing coverage. Please review.

Project coverage is 58.39%. Comparing base (dbfa5c7) to head (46c58b6).

Files with missing lines Patch % Lines
...src/main/java/tech/ydb/table/impl/BaseSession.java 55.00% 21 Missing and 6 partials ⚠️
...h/ydb/table/description/ChangefeedDescription.java 86.20% 2 Missing and 2 partials ⚠️
.../main/java/tech/ydb/table/settings/Changefeed.java 83.33% 3 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##             master     #369      +/-   ##
============================================
+ Coverage     57.72%   58.39%   +0.66%     
- Complexity     2055     2092      +37     
============================================
  Files           311      312       +1     
  Lines         12550    12610      +60     
  Branches       1245     1246       +1     
============================================
+ Hits           7245     7364     +119     
+ Misses         4712     4648      -64     
- Partials        593      598       +5     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@alex268 alex268 merged commit bc59ac1 into ydb-platform:master Feb 10, 2025
8 checks passed
@alex268 alex268 deleted the add_changeset_to_description branch February 10, 2025 12:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Please add support for listing changefeeds/topics of a table

3 participants