Skip to content

Added onLimit method for retryable exceptions #386

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 10, 2025
Merged

Added onLimit method for retryable exceptions #386

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion table/src/main/java/tech/ydb/table/SessionRetryContext.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -266,7 +266,7 @@ private void handleException(@Nonnull Throwable ex) {
handler.onRetry(SessionRetryContext.this, ex, retry, next, ms());
scheduleNext(next);
} else {
handler.onError(SessionRetryContext.this, ex, maxRetries, ms());
handler.onLimit(SessionRetryContext.this, ex, maxRetries, ms());
promise.completeExceptionally(ex);
}
}
Expand Down
14 changes: 14 additions & 0 deletions table/src/main/java/tech/ydb/table/SessionRetryHandler.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -87,6 +87,20 @@ default void onLimit(SessionRetryContext context, StatusCode code,
context.hashCode(), code, retryLimit, millis);
}

/**
* Called on retryable exception when the limit is reached.
*
* @param context Session retry object
* @param issue Retryable exception
* @param retryLimit Maximum number of retries
* @param millis Elapsed time
*/
default void onLimit(SessionRetryContext context, Throwable issue,
int retryLimit, long millis) {
LOGGER.debug("RetryCtx[{}] RETRYABLE ERROR[{}], finished by retries limit ({}), {} ms total",
context.hashCode(), errorMsg(issue), retryLimit, millis);
}

/**
* Called on non-retryable error.
*
Expand Down