Skip to content

Topic fixes #393

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Apr 21, 2025
Merged

Topic fixes #393

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
ed241cb
Disable reconnect of stopped stream
alex268 Apr 18, 2025
e314dad
Supress depracted warnings
alex268 Apr 18, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions topic/src/main/java/tech/ydb/topic/impl/GrpcStreamRetrier.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -92,6 +92,11 @@ private void tryScheduleReconnect() {
}

void reconnect() {
if (isStopped.get()) {
getLogger().info("[{}] {} is already stopped, no need to reconnect", id, getStreamName());
return;
}

getLogger().info("[{}] {} reconnect #{} started", id, getStreamName(), reconnectCounter.get());
if (!isReconnecting.compareAndSet(true, false)) {
getLogger().warn("Couldn't reset reconnect flag. Shouldn't happen");
Expand Down
3 changes: 3 additions & 0 deletions topic/src/main/java/tech/ydb/topic/impl/TopicClientImpl.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -89,6 +89,7 @@ private GrpcRequestSettings makeGrpcRequestSettings(BaseRequestSettings settings
}

@Override
@SuppressWarnings("deprecation")
public CompletableFuture<Status> createTopic(String path, CreateTopicSettings settings) {
YdbTopic.CreateTopicRequest.Builder requestBuilder = YdbTopic.CreateTopicRequest.newBuilder()
.setOperationParams(Operation.buildParams(settings))
Expand Down Expand Up @@ -125,6 +126,7 @@ public CompletableFuture<Status> createTopic(String path, CreateTopicSettings se
}

@Override
@SuppressWarnings("deprecation")
public CompletableFuture<Status> alterTopic(String path, AlterTopicSettings settings) {
YdbTopic.AlterTopicRequest.Builder requestBuilder = YdbTopic.AlterTopicRequest.newBuilder()
.setOperationParams(Operation.buildParams(settings))
Expand Down Expand Up @@ -257,6 +259,7 @@ public CompletableFuture<Result<ConsumerDescription>> describeConsumer(
.thenApply(result -> result.map(ConsumerDescription::new));
}

@SuppressWarnings("deprecation")
private TopicDescription mapDescribeTopic(YdbTopic.DescribeTopicResult result) {
if (logger.isTraceEnabled()) {
logger.trace("Received topic describe response:\n{}", result);
Expand Down