Skip to content

Fixed RuntimeException catching in BaseGrpcTransport #477

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 7, 2025
Merged

Fixed RuntimeException catching in BaseGrpcTransport #477

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
19 changes: 11 additions & 8 deletions core/src/main/java/tech/ydb/core/impl/BaseGrpcTransport.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -95,8 +95,9 @@ public <ReqT, RespT> CompletableFuture<Result<RespT>> unaryCall(
logger.warn("UnaryCall[{}] got unexprected status {}", traceId, ex.getStatus());
return CompletableFuture.completedFuture(Result.fail(ex));
} catch (RuntimeException ex) {
logger.warn("UnaryCall[{}] got problem {}", traceId, ex.getMessage());
return CompletableFuture.completedFuture(Result.error(ex.getMessage(), ex));
String message = ex.getMessage() != null ? ex.getMessage() : ex.toString();
logger.warn("UnaryCall[{}] got problem {}", traceId, message);
return CompletableFuture.completedFuture(Result.error(message, ex));
}
}

Expand Down Expand Up @@ -136,9 +137,10 @@ public <ReqT, RespT> GrpcReadStream<RespT> readStreamCall(
logger.warn("ReadStreamCall[{}] got unexpected status {}", traceId, ex.getStatus());
return new EmptyStream<>(ex.getStatus());
} catch (RuntimeException ex) {
logger.warn("ReadStreamCall[{}] got problem {}", traceId, ex.getMessage());
Issue issue = Issue.of(ex.getMessage(), Issue.Severity.ERROR);
return new EmptyStream<>(Status.of(StatusCode.CLIENT_INTERNAL_ERROR, issue));
String message = ex.getMessage() != null ? ex.getMessage() : ex.toString();
logger.warn("ReadStreamCall[{}] got problem {}", traceId, message);
Issue issue = Issue.of(message, Issue.Severity.ERROR);
return new EmptyStream<>(Status.of(StatusCode.CLIENT_INTERNAL_ERROR, ex, issue));
}
}

Expand Down Expand Up @@ -180,9 +182,10 @@ traceId, call, makeMetadataFromSettings(settings), getAuthCallOptions(), handler
logger.warn("ReadWriteStreamCall[{}] got unexpected status {}", traceId, ex.getStatus());
return new EmptyStream<>(ex.getStatus());
} catch (RuntimeException ex) {
logger.warn("ReadWriteStreamCall[{}] got problem {}", traceId, ex.getMessage());
Issue issue = Issue.of(ex.getMessage(), Issue.Severity.ERROR);
return new EmptyStream<>(Status.of(StatusCode.CLIENT_INTERNAL_ERROR, issue));
String message = ex.getMessage() != null ? ex.getMessage() : ex.toString();
logger.warn("ReadWriteStreamCall[{}] got problem {}", traceId, message);
Issue issue = Issue.of(message, Issue.Severity.ERROR);
return new EmptyStream<>(Status.of(StatusCode.CLIENT_INTERNAL_ERROR, ex, issue));
}
}

Expand Down