Skip to content

Conversation

@ekuvardin
Copy link
Contributor

Connected to #405

Add DescribeTableOptions.
Add tests. So it's difficult to add in a YDB custom TableProfileDescription while running tests. So that test covers default profiles, caching options and profile description, which is set up in the default container.
So try to check only default values and don't dive deep.

For example:

  1. In PartitioningPolicyDescription, don't check if labels contain split_threshold or auto_split.
  2. In ExecutionPolicyDescription, don't check if labels contain pipeline_width or bloom filter.

Because these values can be changed in future releases, tests shouldn't fail if some values change.

Only check StoragePolicyDescription in deep because I think its values are more static.

@codecov-commenter
Copy link

codecov-commenter commented May 28, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 58.87%. Comparing base (f5b5df8) to head (f72bcc0).
Report is 7 commits behind head on master.

Additional details and impacted files
@@             Coverage Diff              @@
##             master     #494      +/-   ##
============================================
+ Coverage     58.70%   58.87%   +0.16%     
- Complexity     2183     2212      +29     
============================================
  Files           325      327       +2     
  Lines         13093    13421     +328     
  Branches       1278     1337      +59     
============================================
+ Hits           7686     7901     +215     
- Misses         4784     4899     +115     
+ Partials        623      621       -2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@alex268 alex268 merged commit ce99e84 into ydb-platform:master May 28, 2025
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants