Skip to content

Conversation

@Eistern
Copy link

@Eistern Eistern commented May 30, 2025

Summary

This PR introduces support for the max_active_partitions parameter in topic control plane operations, providing more precise control over partition auto-merging behavior.

Changes

Added new maxActivePartitions field and corresponding getters/setters in partitioning settings classes
Implemented support for setting and retrieving maxActivePartitions in topic client implementation
Deprecated partitionCountLimit in favor of maxActivePartitions as described in the YDB proto specifications - https://github.com/ydb-platform/ydb/blob/7b288ef1f52ea97c71014dac8ee95bbde82bd6e3/ydb/public/api/protos/ydb_topic.proto#L909

@codecov-commenter
Copy link

Codecov Report

Attention: Patch coverage is 27.77778% with 13 lines in your changes missing coverage. Please review.

Project coverage is 58.93%. Comparing base (c91ad03) to head (5216bbd).
Report is 7 commits behind head on master.

Files with missing lines Patch % Lines
.../ydb/topic/settings/AlterPartitioningSettings.java 0.00% 5 Missing ⚠️
.../tech/ydb/topic/settings/PartitioningSettings.java 44.44% 5 Missing ⚠️
...main/java/tech/ydb/topic/impl/TopicClientImpl.java 25.00% 3 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##             master     #496      +/-   ##
============================================
+ Coverage     58.15%   58.93%   +0.77%     
- Complexity     2183     2220      +37     
============================================
  Files           325      327       +2     
  Lines         13216    13444     +228     
  Branches       1330     1339       +9     
============================================
+ Hits           7686     7923     +237     
+ Misses         4907     4899       -8     
+ Partials        623      622       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@alex268 alex268 requested review from alex268 and pnv1 June 2, 2025 08:24
@alex268 alex268 merged commit 1c523fc into ydb-platform:master Jun 2, 2025
10 checks passed
@Eistern Eistern deleted the feature/add-max-active-partitions branch June 2, 2025 12:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants