Skip to content

Conversation

@alex268
Copy link
Member

@alex268 alex268 commented Sep 2, 2025

No description provided.

@alex268 alex268 requested a review from pnv1 September 2, 2025 08:48
@codecov-commenter
Copy link

codecov-commenter commented Sep 2, 2025

Codecov Report

❌ Patch coverage is 76.78571% with 13 lines in your changes missing coverage. Please review.
✅ Project coverage is 61.66%. Comparing base (8f86524) to head (aff5950).

Files with missing lines Patch % Lines
...ain/java/tech/ydb/core/impl/BaseGrpcTransport.java 57.14% 1 Missing and 2 partials ⚠️
...java/tech/ydb/core/impl/MultiChannelTransport.java 0.00% 3 Missing ⚠️
...n/java/tech/ydb/core/grpc/GrpcRequestSettings.java 80.00% 2 Missing ⚠️
...main/java/tech/ydb/core/impl/YdbTransportImpl.java 33.33% 2 Missing ⚠️
...n/java/tech/ydb/core/impl/call/ReadStreamCall.java 0.00% 1 Missing ⚠️
...a/tech/ydb/core/impl/call/ReadWriteStreamCall.java 0.00% 1 Missing ⚠️
...src/main/java/tech/ydb/query/impl/SessionImpl.java 80.00% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##             master     #535      +/-   ##
============================================
+ Coverage     61.59%   61.66%   +0.06%     
- Complexity     2319     2323       +4     
============================================
  Files           328      328              
  Lines         13538    13558      +20     
  Branches       1354     1358       +4     
============================================
+ Hits           8339     8360      +21     
+ Misses         4560     4557       -3     
- Partials        639      641       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@alex268 alex268 changed the title Added custom modes to pick a channel from the pool Added endpoint pessimization when CreateSession returns OVERLOADED Sep 2, 2025

logger.trace("Endpoint {} was pessimized. New pessimization ratio: {}/{}",
endpoint, newPessimizedCount, records.size());
logger.warn("Endpoint {} was pessimized {}. New pessimization ratio: {}/{}",
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd say INFO at most... Receiving a retriable error (which can lead to endpoint pessimization) does not deserve a warning message

@alex268 alex268 merged commit 9c7051c into ydb-platform:master Sep 2, 2025
17 of 25 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants