-
Notifications
You must be signed in to change notification settings - Fork 31
Added endpoint pessimization when CreateSession returns OVERLOADED #535
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## master #535 +/- ##
============================================
+ Coverage 61.59% 61.66% +0.06%
- Complexity 2319 2323 +4
============================================
Files 328 328
Lines 13538 13558 +20
Branches 1354 1358 +4
============================================
+ Hits 8339 8360 +21
+ Misses 4560 4557 -3
- Partials 639 641 +2 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
|
||
| logger.trace("Endpoint {} was pessimized. New pessimization ratio: {}/{}", | ||
| endpoint, newPessimizedCount, records.size()); | ||
| logger.warn("Endpoint {} was pessimized {}. New pessimization ratio: {}/{}", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'd say INFO at most... Receiving a retriable error (which can lead to endpoint pessimization) does not deserve a warning message
No description provided.