Skip to content

Conversation

@nikitka
Copy link
Contributor

@nikitka nikitka commented Oct 7, 2024

Pull request type

Please check the type of change your PR introduces:

  • Bugfix
  • Feature
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • Documentation content changes
  • Other (please describe):

What is the current behavior?

No way to enable ip discovery support

What is the new behavior?

I've extended .spec.service.grpc with a new ipDiscovery key:

spec:
  service:
    grpc:
      ipDiscovery:
        enabled: true/false
        targetNameOverride: "fqdn to override client tls certificate check"
        ipFamily: IPv4 | IPv6  

If enabled operator will add --grpc-public-target-name-override, --grpc-public-address-v4 or --grpc-public-address-v6 parameters to ydb container command line.

Other information

@nikitka nikitka force-pushed the grpc-public-ip branch 3 times, most recently from ee0d609 to df75d2b Compare October 8, 2024 11:20
@nikitka nikitka marked this pull request as ready for review October 8, 2024 16:32
@nikitka nikitka requested a review from kobzonega October 8, 2024 16:34
Copy link
Contributor

@kobzonega kobzonega left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

also bump helm chart version before merge

@nikitka nikitka merged commit fb2ebe4 into ydb-platform:master Oct 10, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants