Skip to content

Conversation

@kobzonega
Copy link
Contributor

@kobzonega kobzonega commented Jan 4, 2025

Pull request type

Please check the type of change your PR introduces:

  • Bugfix
  • Feature
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • Documentation content changes
  • Other (please describe):

What is the current behavior?

No way to use Database from outside of Kubernetes cluster without CNI features (i.e. Cilium BGP or l3 custom cni plugins)

What is the new behavior?

  • New field ExternalPort for GRPC Service to override --grpc-public-port arg
  • Use type of GRPC Service to NodePort if new field ExternalPort is specified

Other information

  • Update Makefile by the last github CI changes for local development

@kobzonega kobzonega marked this pull request as draft January 7, 2025 06:26
@kobzonega kobzonega marked this pull request as ready for review January 14, 2025 00:52
@kobzonega kobzonega merged commit 25b0d7a into ydb-platform:master Jan 28, 2025
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants