Add missing ability to configure QueryClientSettings #512
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vgvoleg
force-pushed
the
query_client_settings
branch
from
41caeac to
8c43592
Compare
|
🌋 Here are results of SLO test for Python SDK over Query Service: |
|
🌋 Here are results of SLO test for Python SDK over Table Service: |
vgvoleg
force-pushed
the
query_client_settings
branch
2 times, most recently
from
8c3e524 to
f0a84f6
Compare
vgvoleg
force-pushed
the
query_client_settings
branch
from
f0a84f6 to
e757eef
Compare
rekby
reviewed
Oct 25, 2024
| return settings | ||
|
|
||
|
|
||
| test_td = timedelta(microseconds=-100) |
There was a problem hiding this comment.
why do you need 100 microseconds?
can you use one second or one millisecond?
|
|
||
| test_td = timedelta(microseconds=-100) | ||
| test_now = datetime.utcnow() | ||
| test_today = test_now.date() |
There was a problem hiding this comment.
what about use fixed date/time instead of now?
|
|
||
|
|
||
| params = pytest.mark.parametrize( | ||
| "value,ydb_type,casted_result,uncasted_type", |
There was a problem hiding this comment.
casted_result and uncasted_type are difficult to underdstand.
what about: raw result and native_result?
and always compare values
| self, | ||
| driver: common_utils.SupportedDriverType, | ||
| size: int = 100, | ||
| query_client_settings: Optional[QueryClientSettings] = None, |
There was a problem hiding this comment.
what about explicit named paremeter for the settings?
| self, | ||
| driver: common_utils.SupportedDriverType, | ||
| size: int = 100, | ||
| query_client_settings: Optional[QueryClientSettings] = None, |
vgvoleg
force-pushed
the
query_client_settings
branch
from
db6de2e to
f908698
Compare
vgvoleg
force-pushed
the
query_client_settings
branch
from
f908698 to
54bf667
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull request type
Please check the type of change your PR introduces:
What is the current behavior?
Issue Number: N/A
What is the new behavior?
Other information