Skip to content

Refactor aio tableclient destructor #516

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 1, 2024
Merged

Refactor aio tableclient destructor #516

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 6 additions & 4 deletions ydb/aio/table.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -154,10 +154,11 @@ def __init__(self, driver, table_client_settings=None):
self._pool: Optional[SessionPool] = None

def __del__(self):
try:
asyncio.get_running_loop().call_soon(self._stop_pool_if_needed)
except Exception:
pass
if self._pool is not None and not self._pool._terminating:
try:
asyncio.get_running_loop().create_task(self._stop_pool_if_needed())
except Exception:
pass

def session(self):
return Session(self._driver, self._table_client_settings)
Expand Down Expand Up @@ -185,6 +186,7 @@ def _init_pool_if_needed(self):
async def _stop_pool_if_needed(self, timeout=10):
if self._pool is not None and not self._pool._terminating:
await self._pool.stop(timeout=timeout)
self._pool = None

async def create_table(
self,
Expand Down
Loading