Skip to content

Conversation

GrigoriyPA
Copy link
Collaborator

Changelog entry

Fixed streaming query creation with another operations

Changelog category

  • Bugfix

Description for reviewers

Bug ticket: YQ-4778

@GrigoriyPA GrigoriyPA requested review from a team as code owners October 8, 2025 10:43
@github-actions github-actions bot added the bugfix label Oct 8, 2025
@GrigoriyPA GrigoriyPA requested a review from Copilot October 8, 2025 10:45
Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR fixes a bug where streaming query creation would fail when combined with other DDL operations like CREATE SECRET or GRANT statements. The fix involves updating the intent determination transformer to properly handle these operations instead of throwing errors.

Key changes:

  • Modified the intent determination transformer to handle DDL operations alongside streaming queries
  • Updated test fixture to use proper authentication setup for multi-operation scenarios
  • Added comprehensive test coverage for streaming queries with mixed DDL operations

Reviewed Changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.

File Description
ydb/core/kqp/provider/yql_kikimr_datasink.cpp Replaced error returns with Y_UNUSED macros for DDL operations in intent determination transformer
ydb/core/kqp/ut/federated_query/datastreams/datastreams_ut.cpp Enhanced test to include CREATE SECRET and GRANT operations with streaming query creation

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

Copy link

github-actions bot commented Oct 8, 2025

2025-10-08 10:46:44 UTC Pre-commit check linux-x86_64-relwithdebinfo for 948656d has started.
2025-10-08 10:46:58 UTC Artifacts will be uploaded here
2025-10-08 10:50:35 UTC ya make is running...
🟡 2025-10-08 12:20:59 UTC Some tests failed, follow the links below. Going to retry failed tests...

Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
39002 36221 0 4 2743 34

2025-10-08 12:21:10 UTC ya make is running... (failed tests rerun, try 2)
🟢 2025-10-08 12:35:28 UTC Tests successful.

Ya make output | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
561 (only retried tests) 540 0 0 1 20

🟢 2025-10-08 12:35:31 UTC Build successful.
🟢 2025-10-08 12:35:48 UTC ydbd size 2.3 GiB changed* by -30.1 KiB, which is <= 0 Bytes vs main: OK

ydbd size dash main: c38c114 merge: 948656d diff diff %
ydbd size 2 418 004 960 Bytes 2 417 974 104 Bytes -30.1 KiB -0.001%
ydbd stripped size 515 030 344 Bytes 515 023 048 Bytes -7.1 KiB -0.001%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

Copy link

github-actions bot commented Oct 8, 2025

🟢 2025-10-08 10:47:07 UTC The validation of the Pull Request description is successful.

Copy link

github-actions bot commented Oct 8, 2025

2025-10-08 10:47:20 UTC Pre-commit check linux-x86_64-release-asan for 948656d has started.
2025-10-08 10:47:33 UTC Artifacts will be uploaded here
2025-10-08 10:51:09 UTC ya make is running...
🟡 2025-10-08 12:52:45 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet

Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
16051 15586 0 199 245 21

🟢 2025-10-08 12:52:51 UTC Build successful.
🟢 2025-10-08 12:53:16 UTC ydbd size 3.7 GiB changed* by -79.9 KiB, which is <= 0 Bytes vs main: OK

ydbd size dash main: bcd70e0 merge: 948656d diff diff %
ydbd size 4 021 213 064 Bytes 4 021 131 200 Bytes -79.9 KiB -0.002%
ydbd stripped size 1 494 061 888 Bytes 1 494 026 944 Bytes -34.1 KiB -0.002%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

@GrigoriyPA GrigoriyPA requested a review from gridnevvvit October 8, 2025 19:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants