-
Notifications
You must be signed in to change notification settings - Fork 723
YQ-4778 fixed streaming query creation with another operations #26550
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
YQ-4778 fixed streaming query creation with another operations #26550
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR fixes a bug where streaming query creation would fail when combined with other DDL operations like CREATE SECRET or GRANT statements. The fix involves updating the intent determination transformer to properly handle these operations instead of throwing errors.
Key changes:
- Modified the intent determination transformer to handle DDL operations alongside streaming queries
- Updated test fixture to use proper authentication setup for multi-operation scenarios
- Added comprehensive test coverage for streaming queries with mixed DDL operations
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
File | Description |
---|---|
ydb/core/kqp/provider/yql_kikimr_datasink.cpp | Replaced error returns with Y_UNUSED macros for DDL operations in intent determination transformer |
ydb/core/kqp/ut/federated_query/datastreams/datastreams_ut.cpp | Enhanced test to include CREATE SECRET and GRANT operations with streaming query creation |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
⚪ ⚪ Ya make output | Test bloat | Test bloat
🟢
*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation |
🟢 |
⚪
🟢
*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation |
Changelog entry
Fixed streaming query creation with another operations
Changelog category
Description for reviewers
Bug ticket: YQ-4778