-
Notifications
You must be signed in to change notification settings - Fork 723
YQ-4779 fixed ACK sending for sys view scan #26552
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
YQ-4779 fixed ACK sending for sys view scan #26552
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR fixes ACK sending for system view scan operations by introducing a new TScanActorWithoutBackPressure
base class and preventing duplicate scan initialization across multiple system view scan actors.
- Introduced
TScanActorWithoutBackPressure
template class to handle ACK processing without backpressure - Added guards to prevent duplicate scan requests in tablet and query stats scan actors
- Refactored multiple system view scan classes to use the new base class and simplified ACK handling
Reviewed Changes
Copilot reviewed 13 out of 13 changed files in this pull request and generated 3 comments.
Show a summary per file
File | Description |
---|---|
ydb/core/sys_view/common/scan_actor_base_impl.h | Added new TScanActorWithoutBackPressure template class |
ydb/core/sys_view/tablets/tablets.cpp | Added guard to prevent duplicate tablet ID requests |
ydb/core/sys_view/query_stats/query_stats.cpp | Added guard to prevent duplicate old scan initialization |
ydb/core/sys_view/storage/base.h | Migrated to use TScanActorWithoutBackPressure base class |
ydb/core/sys_view/show_create/show_create.cpp | Migrated to use TScanActorWithoutBackPressure base class |
ydb/core/sys_view/resource_pools/resource_pools.cpp | Migrated to use TScanActorWithoutBackPressure base class |
ydb/core/sys_view/resource_pool_classifiers/resource_pool_classifiers.cpp | Migrated to use TScanActorWithoutBackPressure base class |
ydb/core/sys_view/nodes/nodes.cpp | Migrated to use TScanActorWithoutBackPressure base class |
ydb/core/sys_view/compile_cache/compile_cache.cpp | Added guard for pending proxy node requests and improved initialization |
ydb/core/sys_view/auth/users.cpp | Migrated to use TScanActorWithoutBackPressure base class |
ydb/core/sys_view/auth/auth_scan_base.h | Added guard to prevent duplicate navigation path requests |
ydb/core/kqp/compute_actor/kqp_pure_compute_actor.h | Added new methods for source polling and free space calculation |
ydb/core/kqp/compute_actor/kqp_pure_compute_actor.cpp | Implemented source polling logic and refactored free space calculation |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
🟢 |
Co-authored-by: Copilot <[email protected]>
⚪
🟢
*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation |
⚪ ⚪ Ya make output | Test bloat | Test bloat
⚪ Ya make output | Test bloat | Test bloat | Test bloat
🟢
*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation |
Changelog entry
Fixed ACK sending for sys view scan
Changelog category
Description for reviewers
Bugfix ticket: YQ-4779