Skip to content

YQ-4779 fixed ACK sending for sys view scan #26552

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

YQ-4779 fixed ACK sending for sys view scan #26552

wants to merge 2 commits into from
+130 −109

Conversation

GrigoriyPA
Copy link
Collaborator

Changelog entry

Fixed ACK sending for sys view scan

Changelog category

  • Bugfix

Description for reviewers

Bugfix ticket: YQ-4779

@GrigoriyPA GrigoriyPA requested a review from a team as a code owner October 8, 2025 11:00
@github-actions github-actions bot added the bugfix label Oct 8, 2025
Copilot
Copilot AI reviewed Oct 8, 2025
View reviewed changes
Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR fixes ACK sending for system view scan operations by introducing a new TScanActorWithoutBackPressure base class and preventing duplicate scan initialization across multiple system view scan actors.

  • Introduced TScanActorWithoutBackPressure template class to handle ACK processing without backpressure
  • Added guards to prevent duplicate scan requests in tablet and query stats scan actors
  • Refactored multiple system view scan classes to use the new base class and simplified ACK handling

Reviewed Changes

Copilot reviewed 13 out of 13 changed files in this pull request and generated 3 comments.

Show a summary per file
File Description
ydb/core/sys_view/common/scan_actor_base_impl.h Added new TScanActorWithoutBackPressure template class
ydb/core/sys_view/tablets/tablets.cpp Added guard to prevent duplicate tablet ID requests
ydb/core/sys_view/query_stats/query_stats.cpp Added guard to prevent duplicate old scan initialization
ydb/core/sys_view/storage/base.h Migrated to use TScanActorWithoutBackPressure base class
ydb/core/sys_view/show_create/show_create.cpp Migrated to use TScanActorWithoutBackPressure base class
ydb/core/sys_view/resource_pools/resource_pools.cpp Migrated to use TScanActorWithoutBackPressure base class
ydb/core/sys_view/resource_pool_classifiers/resource_pool_classifiers.cpp Migrated to use TScanActorWithoutBackPressure base class
ydb/core/sys_view/nodes/nodes.cpp Migrated to use TScanActorWithoutBackPressure base class
ydb/core/sys_view/compile_cache/compile_cache.cpp Added guard for pending proxy node requests and improved initialization
ydb/core/sys_view/auth/users.cpp Migrated to use TScanActorWithoutBackPressure base class
ydb/core/sys_view/auth/auth_scan_base.h Added guard to prevent duplicate navigation path requests
ydb/core/kqp/compute_actor/kqp_pure_compute_actor.h Added new methods for source polling and free space calculation
ydb/core/kqp/compute_actor/kqp_pure_compute_actor.cpp Implemented source polling logic and refactored free space calculation

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

@github-actions GitHub Actions
Copy link

github-actions bot commented Oct 8, 2025

🟢 2025-10-08 11:01:24 UTC The validation of the Pull Request description is successful.

@github-actions GitHub Actions
Copy link

github-actions bot commented Oct 8, 2025 •
edited
Loading

⚪ 2025-10-08 11:03:05 UTC Pre-commit check linux-x86_64-relwithdebinfo for 9c96d7e has started.
⚪ 2025-10-08 11:03:35 UTC Artifacts will be uploaded here
⚫ 2025-10-08 11:06:32 UTC Check cancelled

@github-actions GitHub Actions
Copy link

github-actions bot commented Oct 8, 2025 •
edited
Loading

⚪ 2025-10-08 11:04:36 UTC Pre-commit check linux-x86_64-release-asan for 9c96d7e has started.
⚪ 2025-10-08 11:04:53 UTC Artifacts will be uploaded here
⚫ 2025-10-08 11:06:32 UTC Check cancelled

@github-actions GitHub Actions
Copy link

github-actions bot commented Oct 8, 2025 •
edited
Loading

⚪ 2025-10-08 11:09:49 UTC Pre-commit check linux-x86_64-release-asan for a86c33c has started.
⚪ 2025-10-08 11:10:03 UTC Artifacts will be uploaded here
⚪ 2025-10-08 11:13:44 UTC ya make is running...
🟡 2025-10-08 13:45:30 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet

Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
15722 15247 0 179 273 23

🟢 2025-10-08 13:45:37 UTC Build successful.
🟡 2025-10-08 13:46:04 UTC ydbd size 3.7 GiB changed* by +311.1 KiB, which is >= 100.0 KiB vs main: Warning

ydbd size dash main: c38c114 merge: a86c33c diff diff %
ydbd size 4 021 180 208 Bytes 4 021 498 728 Bytes +311.1 KiB +0.008%
ydbd stripped size 1 494 048 320 Bytes 1 494 062 784 Bytes +14.1 KiB +0.001%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

@github-actions GitHub Actions
Copy link

github-actions bot commented Oct 8, 2025 •
edited
Loading

⚪ 2025-10-08 11:12:48 UTC Pre-commit check linux-x86_64-relwithdebinfo for a86c33c has started.
⚪ 2025-10-08 11:12:52 UTC Artifacts will be uploaded here
⚪ 2025-10-08 11:16:22 UTC ya make is running...
🟡 2025-10-08 12:57:08 UTC Some tests failed, follow the links below. Going to retry failed tests...

Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
38673 35909 0 3 2739 22

⚪ 2025-10-08 12:57:20 UTC ya make is running... (failed tests rerun, try 2)
🟡 2025-10-08 13:14:29 UTC Some tests failed, follow the links below. Going to retry failed tests...

Ya make output | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
263 (only retried tests) 245 0 1 0 17

⚪ 2025-10-08 13:14:32 UTC ya make is running... (failed tests rerun, try 3)
🟢 2025-10-08 13:23:49 UTC Tests successful.

Ya make output | Test bloat | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
188 (only retried tests) 173 0 0 0 15

🟢 2025-10-08 13:23:52 UTC Build successful.
🟢 2025-10-08 13:24:10 UTC ydbd size 2.3 GiB changed* by +12.5 KiB, which is < 100.0 KiB vs main: OK

ydbd size dash main: c38c114 merge: a86c33c diff diff %
ydbd size 2 418 004 960 Bytes 2 418 017 768 Bytes +12.5 KiB +0.001%
ydbd stripped size 515 030 344 Bytes 515 032 968 Bytes +2.6 KiB +0.001%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

Copilot code review Copilot Copilot left review comments

@gridnevvvit gridnevvvit Awaiting requested review from gridnevvvit

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
bugfix
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@GrigoriyPA