Skip to content

Conversation

@naspirato
Copy link
Collaborator

@naspirato naspirato commented Jan 4, 2026

Changelog entry

OOM в запуске relwithdebinfo пропал #31669 (comment)
image

было #31669 (comment)
image

Changelog category

  • Not for changelog (changelog entry is not required)

Description for reviewers

...

Added resource requirements for the test.
Removed executor configurations and added auto config settings.
Added resource requirements for the test.
Removed conditional requirements for sanitizer type.
Added resource requirements for the test scheme shard.
Added resource requirements for the test environment.
Added resource requirements for the test environment.
Add resource requirements for test execution
Added resource requirements for the test.
Add resource requirements for the test
Add requirements for RAM and CPU to ya.make
@github-actions
Copy link

github-actions bot commented Jan 4, 2026

2026-01-04 21:56:10 UTC Pre-commit check linux-x86_64-relwithdebinfo for d89299a has started.
2026-01-04 21:56:26 UTC Artifacts will be uploaded here
2026-01-04 21:58:43 UTC ya make is running...
2026-01-04 22:08:09 UTC Check cancelled

@ydbot
Copy link
Collaborator

ydbot commented Jan 4, 2026

Run Extra Tests

Run additional tests for this PR. You can customize:

  • Test Size: small, medium, large (default: all)
  • Test Targets: any directory path (default: ydb/)
  • Sanitizers: ASAN, MSAN, TSAN
  • Coredumps: enable for debugging (default: off)
  • Additional args: custom ya make arguments

▶  Run tests

@github-actions
Copy link

github-actions bot commented Jan 4, 2026

🟢 2026-01-04 21:58:02 UTC The validation of the Pull Request description is successful.

@naspirato naspirato marked this pull request as ready for review January 4, 2026 21:57
@naspirato naspirato requested a review from a team as a code owner January 4, 2026 21:57
Copilot AI review requested due to automatic review settings January 4, 2026 21:57
@naspirato naspirato enabled auto-merge (squash) January 4, 2026 21:58
@github-actions
Copy link

github-actions bot commented Jan 4, 2026

2026-01-04 21:58:54 UTC Pre-commit check linux-x86_64-release-asan for d89299a has started.
2026-01-04 21:59:13 UTC Artifacts will be uploaded here
2026-01-04 22:01:25 UTC ya make is running...
2026-01-04 22:08:08 UTC Check cancelled

Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR addresses Out Of Memory (OOM) issues in RelWithDebInfo builds by standardizing resource requirements across test configurations. The changes ensure that tests have adequate RAM (32GB) and CPU (4 cores) allocated, regardless of build type.

Key changes:

  • Standardized resource requirements to ram:32 cpu:4 across multiple test suites
  • Removed SANITIZER_TYPE conditionals where requirements are now unconditional
  • Added ELSE clauses to apply requirements to non-sanitizer builds where conditionals remain

Reviewed changes

Copilot reviewed 26 out of 26 changed files in this pull request and generated 1 comment.

Show a summary per file
File Description
ydb/tests/stress/viewer/tests/ya.make Removed SANITIZER_TYPE conditional, made resource requirements unconditional
ydb/tests/olap/scenario/ya.make Added resource requirements for OLAP scenario tests
ydb/tests/olap/column_family/compression/ya.make Added resource requirements for compression tests
ydb/tests/functional/sqs/messaging/ya.make Added resource requirements for non-sanitizer builds
ydb/tests/functional/sqs/large/ya.make Added resource requirements for non-sanitizer builds
ydb/tests/functional/sqs/cloud/ya.make Added resource requirements for non-sanitizer builds
ydb/tests/functional/serverless/ya.make Removed SANITIZER_TYPE conditional, made resource requirements unconditional
ydb/tests/functional/scheme_shard/ya.make Added resource requirements for scheme shard tests
ydb/tests/functional/restarts/ya.make Removed SANITIZER_TYPE conditional, made resource requirements unconditional
ydb/tests/functional/rename/ya.make Added resource requirements for non-sanitizer builds
ydb/tests/functional/hive/ya.make Added resource requirements for non-sanitizer builds (16GB RAM)
ydb/tests/functional/encryption/ya.make Removed SANITIZER_TYPE conditional, made resource requirements unconditional
ydb/tests/functional/cms/ya.make Added resource requirements for non-sanitizer builds (identical to sanitizer builds)
ydb/tests/fq/yds/ya.make Added resource requirements for yds tests
ydb/tests/datashard/vector_index/medium/ya.make Added resource requirements before size conditional
ydb/tests/datashard/ttl/ya.make Added resource requirements for TTL tests
ydb/tests/datashard/split_merge/ya.make Added resource requirements for split/merge tests
ydb/tests/datashard/select/ya.make Added resource requirements for select tests
ydb/tests/datashard/s3/ya.make Added resource requirements for S3 tests
ydb/tests/datashard/partitioning/ya.make Added resource requirements for partitioning tests
ydb/tests/datashard/parametrized_queries/ya.make Added resource requirements for parametrized query tests
ydb/tests/datashard/dump_restore/ya.make Added resource requirements for dump/restore tests
ydb/tests/datashard/dml/ya.make Added resource requirements for DML tests
ydb/tests/datashard/copy_table/ya.make Added resource requirements for copy table tests
ydb/tests/datashard/async_replication/ya.make Added resource requirements for async replication tests
ydb/tests/datashard/add_column/ya.make Added resource requirements for add column tests

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
@github-actions
Copy link

github-actions bot commented Jan 4, 2026

Run-tests started

  • Build Preset: relwithdebinfo
  • Test Size: small,medium
  • Test Targets: ydb/
  • Commit: 2b7566c
  • Workflow run: link

2026-01-04 22:08:35 UTC Artifacts will be uploaded here
2026-01-04 22:09:29 UTC ya make is running...
🟡 2026-01-05 00:29:10 UTC Some tests failed, follow the links below. Going to retry failed tests...

Details

Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
47542 44277 0 6 3224 35

2026-01-05 00:29:31 UTC ya make is running... (failed tests rerun, try 2)
🟢 2026-01-05 00:37:39 UTC Tests successful.

Ya make output | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
818 (only retried tests) 804 0 0 0 14

🟢 2026-01-05 00:37:48 UTC Build successful.

@github-actions
Copy link

github-actions bot commented Jan 4, 2026

2026-01-04 22:08:36 UTC Pre-commit check linux-x86_64-release-asan for 2b7566c has started.
2026-01-04 22:08:44 UTC Artifacts will be uploaded here
2026-01-04 22:10:07 UTC ya make is running...
🟢 2026-01-04 22:44:31 UTC Tests successful.

Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
1106 1097 0 0 1 8

🟢 2026-01-04 22:44:38 UTC Build successful.
🟢 2026-01-04 22:44:57 UTC ydbd size 3.8 GiB changed* by -96 Bytes, which is <= 0 Bytes vs main: OK

ydbd size dash main: 86bc6db merge: 2b7566c diff diff %
ydbd size 4 104 383 000 Bytes 4 104 382 904 Bytes -96 Bytes -0.000%
ydbd stripped size 1 535 379 696 Bytes 1 535 379 632 Bytes -64 Bytes -0.000%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

@github-actions
Copy link

github-actions bot commented Jan 4, 2026

2026-01-04 22:09:40 UTC Pre-commit check linux-x86_64-relwithdebinfo for 2b7566c has started.
2026-01-04 22:09:56 UTC Artifacts will be uploaded here
2026-01-04 22:12:06 UTC ya make is running...
🟡 2026-01-04 22:45:35 UTC Some tests failed, follow the links below. Going to retry failed tests...

Details

Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
1892 1875 0 1 8 8

2026-01-04 22:45:41 UTC ya make is running... (failed tests rerun, try 2)
🟡 2026-01-04 23:00:06 UTC Some tests failed, follow the links below. Going to retry failed tests...

Details

Ya make output | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
57 (only retried tests) 52 0 1 0 4

2026-01-04 23:00:13 UTC ya make is running... (failed tests rerun, try 3)
🟢 2026-01-04 23:03:27 UTC Tests successful.

Ya make output | Test bloat | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
55 (only retried tests) 51 0 0 0 4

🟢 2026-01-04 23:03:34 UTC Build successful.
🟢 2026-01-04 23:03:55 UTC ydbd size 2.3 GiB changed* by 0 Bytes, which is <= 0 Bytes vs main: OK

ydbd size dash main: 86bc6db merge: 2b7566c diff diff %
ydbd size 2 495 882 808 Bytes 2 495 882 808 Bytes 0 Bytes 0.000%
ydbd stripped size 530 643 520 Bytes 530 643 520 Bytes 0 Bytes 0.000%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants