-
Notifications
You must be signed in to change notification settings - Fork 749
Add TRUNCATE TABLE implementation for tables with vector indexes #32922
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Add TRUNCATE TABLE implementation for tables with vector indexes #32922
Conversation
4a94638 to
d18768c
Compare
d18768c to
ffe7590
Compare
|
🟢 |
|
⚪ ⚪ Ya make output | Test bloat | Test bloat
🟢
*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation |
|
⚪
🟢
*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation |
| size_t numberOfChildren = srcChildPath.Base()->GetChildren().size(); | ||
| Y_ABORT_UNLESS(numberOfChildren == 2 || numberOfChildren == 3); | ||
|
|
||
| if (numberOfChildren == 2) { // GlobalVectorIndex contains two implTables |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
в принципе всё норм, вот только не хотелось бы по numberOfChildren ориентироваться. вдруг в будущем ещё какая таблица появится? проверь плз по числу индексных полей, если поле одно то это глобальный индекс, если > 1 то префиксный
Changelog category
Description for reviewers
This PR adds the ability to run TRUNCATE TABLE on tables that have global vector index and prefix vector index.