Skip to content

[Backport stable-25-3-1] PR #34447: Fix VERIFY caused by dstool group take-snapshot when VDisk is in NotReady or Error state#34474

Open
ydbot wants to merge 2 commits intostable-25-3-1from
cherry-pick-stable-25-3-1-260219-084812
Open

[Backport stable-25-3-1] PR #34447: Fix VERIFY caused by dstool group take-snapshot when VDisk is in NotReady or Error state#34474
ydbot wants to merge 2 commits intostable-25-3-1from
cherry-pick-stable-25-3-1-260219-084812

Conversation

@ydbot
Copy link
Collaborator

@ydbot ydbot commented Feb 19, 2026

Changelog entry

Fix VERIFY caused by dstool group take-snapshot when VDisk is in NotReady or Error state: - Fix VERIFY caused by dstool group take-snapshot when VDisk is in NotReady or Error state

Changelog category

  • Not for changelog (changelog entry is not required)

Description for reviewers

Original PR(s)

Metadata

  • Original PR author(s): @rosik
  • Cherry-picked by: @rosik
  • Related issues: None

Conflicts Require Manual Resolution

This PR contains merge conflicts that require manual resolution.

Files with conflicts:

How to resolve conflicts:

git fetch origin
git checkout --track origin/cherry-pick-stable-25-3-1-260219-084812
# Resolve conflicts in files
git add .
git commit -m "Resolved merge conflicts"
git push

After resolving conflicts:

  1. Fix the PR title (remove [CONFLICT] if conflicts are resolved)
  2. Mark PR as ready for review

Git Cherry-Pick Log

=== Cherry-picking 2cf22b8 ===
Auto-merging ydb/core/blobstorage/vdisk/skeleton/blobstorage_skeletonfront.cpp
Auto-merging ydb/tests/functional/dstool/canondata/result.json
CONFLICT (content): Merge conflict in ydb/tests/functional/dstool/canondata/result.json
Auto-merging ydb/tests/functional/dstool/test_canonical_requests.py
CONFLICT (content): Merge conflict in ydb/tests/functional/dstool/test_canonical_requests.py

error: could not apply 2cf22b8ae96... Fix VERIFY caused by dstool group take-snapshot when VDisk is in NotReady or Error state (#34447)
hint: After resolving the conflicts, mark them with
hint: "git add/rm <pathspec>", then run
hint: "git cherry-pick --continue".
hint: You can instead skip this commit with "git cherry-pick --skip".
hint: To abort and get back to the state before "git cherry-pick",
hint: run "git cherry-pick --abort".

PR was created by cherry-pick workflow run

@ydbot
Copy link
Collaborator Author

ydbot commented Feb 19, 2026

Run Extra Tests

Run additional tests for this PR. You can customize:

  • Test Size: small, medium, large (default: all)
  • Test Targets: any directory path (default: ydb/)
  • Sanitizers: ASAN, MSAN, TSAN
  • Coredumps: enable for debugging (default: off)
  • Additional args: custom ya make arguments

▶  Run tests

@github-actions
Copy link

github-actions bot commented Feb 19, 2026

2026-02-19 08:49:50 UTC Pre-commit check linux-x86_64-release-asan for dc60f87 has started.
2026-02-19 08:49:54 UTC Artifacts will be uploaded here
2026-02-19 08:53:29 UTC ya make is running...
🔴 2026-02-19 08:55:22 UTC Build failed, see the logs. Also see fail summary

@github-actions
Copy link

github-actions bot commented Feb 19, 2026

2026-02-19 08:49:56 UTC Pre-commit check linux-x86_64-relwithdebinfo for dc60f87 has started.
2026-02-19 08:50:12 UTC Artifacts will be uploaded here
2026-02-19 08:53:46 UTC ya make is running...
🔴 2026-02-19 08:55:29 UTC Build failed, see the logs. Also see fail summary

@github-actions
Copy link

github-actions bot commented Feb 19, 2026

🟢 2026-02-20 14:49:08 UTC The validation of the Pull Request description is successful.

@github-actions
Copy link

github-actions bot commented Feb 20, 2026

2026-02-20 10:54:45 UTC Pre-commit check linux-x86_64-release-asan for 194f451 has started.
2026-02-20 10:54:50 UTC Artifacts will be uploaded here
2026-02-20 10:58:27 UTC ya make is running...
🟡 2026-02-20 12:58:50 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet

Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
16060 15555 0 202 283 20

🟢 2026-02-20 12:58:56 UTC Build successful.
🟢 2026-02-20 12:59:25 UTC ydbd size 3.8 GiB changed* by +304 Bytes, which is < 100.0 KiB vs stable-25-3-1: OK

ydbd size dash stable-25-3-1: fb0fd63 merge: 194f451 diff diff %
ydbd size 4 045 892 376 Bytes 4 045 892 680 Bytes +304 Bytes +0.000%
ydbd stripped size 1 510 544 704 Bytes 1 510 544 832 Bytes +128 Bytes +0.000%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

@github-actions
Copy link

github-actions bot commented Feb 20, 2026

2026-02-20 10:55:06 UTC Pre-commit check linux-x86_64-relwithdebinfo for 194f451 has started.
2026-02-20 10:56:54 UTC Artifacts will be uploaded here
2026-02-20 11:01:16 UTC ya make is running...
🟡 2026-02-20 12:34:21 UTC Some tests failed, follow the links below. Going to retry failed tests...

Details

Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
39100 36400 0 6 2671 23

2026-02-20 12:34:31 UTC ya make is running... (failed tests rerun, try 2)
🟡 2026-02-20 12:55:12 UTC Some tests failed, follow the links below. Going to retry failed tests...

Details

Ya make output | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
894 (only retried tests) 869 0 3 1 21

2026-02-20 12:55:14 UTC ya make is running... (failed tests rerun, try 3)
🟢 2026-02-20 13:13:37 UTC Tests successful.

Ya make output | Test bloat | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
556 (only retried tests) 536 0 0 1 19

🟢 2026-02-20 13:13:40 UTC Build successful.
🟢 2026-02-20 13:14:11 UTC ydbd size 2.3 GiB changed* by +208 Bytes, which is < 100.0 KiB vs stable-25-3-1: OK

ydbd size dash stable-25-3-1: fb0fd63 merge: 194f451 diff diff %
ydbd size 2 429 268 888 Bytes 2 429 269 096 Bytes +208 Bytes +0.000%
ydbd stripped size 520 633 064 Bytes 520 633 128 Bytes +64 Bytes +0.000%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

@rosik rosik changed the title [CONFLICT] [Backport stable-25-3-1] PR #34447: Fix VERIFY caused by dstool group take-snapshot when VDisk is in NotReady or Error state [Backport stable-25-3-1] PR #34447: Fix VERIFY caused by dstool group take-snapshot when VDisk is in NotReady or Error state Feb 20, 2026
@rosik rosik marked this pull request as ready for review February 20, 2026 14:47
@rosik rosik requested a review from a team as a code owner February 20, 2026 14:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

Comments