Skip to content

fix: rebuild staking withdraw path on release#1103

Closed
rossgalloway wants to merge 1 commit intorelease/03-16-26from
fix-staking-to-always-show-withdraw-path-release
Closed

fix: rebuild staking withdraw path on release#1103
rossgalloway wants to merge 1 commit intorelease/03-16-26from
fix-staking-to-always-show-withdraw-path-release

Conversation

@rossgalloway
Copy link
Collaborator

@rossgalloway rossgalloway commented Mar 12, 2026

squashed changes from #1089 pointed at the release branch.

Summary

  • rebuild the staking withdraw-path branch cleanly on top of release/03-16-26
  • preserve the staking/withdraw-path behavior from the original branch without the stale branch drift
  • keep the diff focused so this can be reviewed independently from yvUSD

Here was the description from #1089:

Some staked positions do not show up in the portfolio view and cannot be withdrawn via the usual methods. This PR makes sure they are discoverable and can be withdrawn easily. Because old staking contracts are not always picked up by enso, we can't rely on them to provide routes from them. So we fall back to the old unstake/withdraw logic from staked vaults (including yBOLD)

This PR also includes commits from #1056 which shows strategies that were not previously showing up and gets prices for them. unfortunately, the practice where strategies are not being endorsed, but are still able to be deposited into (and are deposited into by advanced users) is causing issues. We don't have any metadata levers on strategies to force them to be recognized as yearn, so the only way to show them is to pull in all erc-4626 and show them if the user has deposits in them. But now we have to deal with random 4626 strategies showing up in our portfolio and vault lists if users have them in their wallets. So I added tags for non-yearn vault list rows and a warning on non-yearn vault pages that they are not yearn vaults.

Also included in this PR is a change to how hidden vaults are shown. They are now hidden in the portfolio view unless actively turned on in the vault filters. We need to go through the current set of hidden vaults in CMS and unhide any that should still be shown. There are a number than are hidden and retired, but should probably only be hidden. I'll do that tomorrow.

Validation

  • bun run lint
  • bun run build
  • bun run test src/components/pages/vaults/hooks/actions/stakingAdapter.test.ts src/components/pages/vaults/components/widget/shared/TransactionOverlay.test.ts src/components/pages/vaults/components/widget/withdraw/withdrawStepHelpers.test.ts src/components/shared/hooks/useBalancesRouting.test.ts src/components/shared/hooks/useBalancesCombined.test.ts src/components/shared/hooks/useVaultFilterUtils.test.ts src/components/pages/portfolio/hooks/portfolioVisibility.test.ts src/components/pages/vaults/domain/vaultWarnings.test.ts src/components/shared/hooks/useFetchYearnVaults.test.ts

@vercel
Copy link

vercel bot commented Mar 12, 2026

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
yearnfi Ready Ready Preview, Comment Mar 12, 2026 2:05am

Request Review

@github-actions
Copy link

Dependency Review

✅ No vulnerabilities or license issues or OpenSSF Scorecard issues found.

Scanned Files

None

@rossgalloway
Copy link
Collaborator Author

superceded by #1104
functionality incorporated into #1093

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants