feat: reduce useEffect usage

[0xeye]

Based on:
https://react.dev/learn/you-might-not-need-an-effect
https://x.com/alvinsng/status/2033969062834045089

We often hit render loops, usually useEffect is the culprit. We should reduce where possible imo, I think it's good practise

Test:

• Run through app, ensure all working as intended

[vercel]

The latest updates on your projects. Learn more about Vercel for GitHub.

Project	Deployment	Actions	Updated (UTC)
yearnfi	Ready	Preview, Comment	Mar 20, 2026 2:20pm

[github-actions]

Dependency Review

✅ No vulnerabilities or license issues or OpenSSF Scorecard issues found.

Scanned Files

None

[rossgalloway]

Review findings:

1. [P2] Re-require deposit slippage confirmation after any quote change
   This now remembers the user's high-price-impact acknowledgement by priceImpactAcceptanceKey instead of clearing it whenever the quote changes. If someone checks the box for a risky deposit, changes the amount/token so a different quote is shown, and then returns to the original quote, hasAcceptedPriceImpact becomes true again and the deposit CTA is re-enabled without a fresh acknowledgement. That weakens the warning gate compared with the previous boolean-reset behavior.

2. [P2] Re-require withdraw slippage confirmation after any quote change
   This makes the withdraw warning sticky for any previously accepted priceImpactAcceptanceKey. A user can acknowledge a high-impact withdrawal, change inputs so the warning disappears or a different quote is shown, and then come back to the original risky quote with the checkbox already satisfied and the CTA enabled. The prior implementation forced a new acknowledgement after any intermediate quote change, which is the safer behavior for a slippage warning.

Fix PR: #1124