Skip to content

feat: dedupe logic across deposit/withdraw#1121

Open
0xeye wants to merge 3 commits intorelease/04-01-26from
feat/dedupe-deposit
Open

feat: dedupe logic across deposit/withdraw#1121
0xeye wants to merge 3 commits intorelease/04-01-26from
feat/dedupe-deposit

Conversation

@0xeye
Copy link
Collaborator

@0xeye 0xeye commented Mar 18, 2026

Reduce duplicated logic, pull out into shared components / hooks.

Fixes transports failure where it will continually ping bad rpc.

@vercel
Copy link

vercel bot commented Mar 18, 2026

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
yearnfi Ready Ready Preview, Comment Mar 20, 2026 2:21pm

Request Review

@github-actions
Copy link

github-actions bot commented Mar 18, 2026

Dependency Review

✅ No vulnerabilities or license issues or OpenSSF Scorecard issues found.

Scanned Files

None

@rossgalloway
Copy link
Collaborator

rossgalloway commented Mar 19, 2026

Two issues surfaced while reviewing this branch:

  1. src/config/wagmi.ts: enabling ranking across the added public RPC pool can let a faster public endpoint outrank a configured VITE_RPC_URI_FOR_<chain> override. In fork, Tenderly, or other custom-RPC setups that means reads can silently fall back to live chain state even while the override is healthy.
  2. src/components/pages/vaults/components/widget/shared/usePriceImpactAcceptance.ts: the remembered-key acceptance logic recreates the A -> B -> A price-impact confirmation bug, where returning to a previously accepted quote re-checks the warning and re-enables the CTA without a fresh confirmation.

On the second point, this is the same regression class being addressed on top of #1120 in #1124 (Fix price impact confirmation resets).

Follow-up for the RPC-ranking issue is now open as #1126 (Fix RPC override precedence), targeting feat/dedupe-deposit so that fix can merge independently of the broader refactor.

Keep explicit VITE_RPC_URI_FOR_<chain> endpoints ahead of ranked\npublic fallbacks so fork and custom backends do not get\ndemoted behind live RPCs.\n\n- disable fallback ranking when an explicit RPC override is set\n- preserve the existing deduped transport list for non-override cases
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants