feat: dedupe logic across deposit/withdraw#1121
Open
0xeye wants to merge 3 commits intorelease/04-01-26from
Open
feat: dedupe logic across deposit/withdraw#11210xeye wants to merge 3 commits intorelease/04-01-26from
0xeye wants to merge 3 commits intorelease/04-01-26from
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Dependency Review✅ No vulnerabilities or license issues or OpenSSF Scorecard issues found.Scanned FilesNone |
Collaborator
|
Two issues surfaced while reviewing this branch:
On the second point, this is the same regression class being addressed on top of Follow-up for the RPC-ranking issue is now open as |
Keep explicit VITE_RPC_URI_FOR_<chain> endpoints ahead of ranked\npublic fallbacks so fork and custom backends do not get\ndemoted behind live RPCs.\n\n- disable fallback ranking when an explicit RPC override is set\n- preserve the existing deduped transport list for non-override cases
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reduce duplicated logic, pull out into shared components / hooks.
Fixes transports failure where it will continually ping bad rpc.