Merged
Conversation
Keep the vault list aligned with the selected chain filter and\nmake chain switching behave consistently across the page.\n\n- apply selected-chain filtering to holdings in both V2 and V3\n vault filters so other-chain rows do not leak into the list\n- reuse a single-chain selection helper for the top selector and\n row chips so switching chains cannot drift into mixed states\n- add focused tests for selected-chain matching and single-chain\n selection behavior
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Dependency Review✅ No vulnerabilities or license issues or OpenSSF Scorecard issues found.Scanned FilesNone |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
On the main vaults page, selecting a single chain could still show vaults from other chains.
This happened because the V2 and V3 vault filters skipped chain filtering for holdings, so connected-wallet positions on other chains leaked into the list. The page also had two different chain-selection behaviors: the top chain selector behaved like a single-select control, while row-level chain chips could build mixed selections. That mismatch could leave the page feeling stuck in a repeated updating state while switching chains.
Fix
How To Review
All Chains.Testing
bunx vitest run src/components/shared/hooks/useVaultFilterUtils.test.ts src/components/pages/vaults/utils/chainSelection.test.tsbun run tslintbun run lint:fix