Add strategy-level KAT rewards APR display#1128
Open
juniordevbot[bot] wants to merge 6 commits intomainfrom
Open
Add strategy-level KAT rewards APR display#1128juniordevbot[bot] wants to merge 6 commits intomainfrom
juniordevbot[bot] wants to merge 6 commits intomainfrom
Conversation
- Schema: make estimated apr/apy optional (Kong hydration may set only apr for strategy-addressed rows), add katRewardsAPR component - Selector: fall back to estimated.apr for katana strategies when estimated.apy is missing, extract katRewardsAPR from estimated type - Strategy UI: show sword emoji indicator when strategy has KAT rewards - Tests: cover katana strategy APR fallback and non-katana isolation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Dependency Review✅ No vulnerabilities or license issues or OpenSSF Scorecard issues found.Scanned FilesNone |
…kdown - Selector: estimatedAPY now always falls through to oracle.apy for Katana strategies instead of using estimated.apr (which is KAT rewards) - UI: strategy row shows combined APY (oracle + KAT rewards) - UI: hover tooltip breaks down Base APY and KAT Rewards APR - Tooltip follows existing pattern (rounded-lg border surface-secondary) - Tests updated to reflect additive behavior
murderteeth
approved these changes
Mar 20, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Display per-strategy KAT reward APR from Kong composition snapshots. Once katana-apr-service PR #33 merges and the webhook starts emitting strategy-addressed rows, Kong will hydrate
composition[*].performance.estimatedwith strategy-level KAT rewards. This PR makes yearn.fi consume that data.Ref: Kong Integration Guide (yearn/kong#372)
What changed
Schema (
kongVaultSnapshotSchema.ts)aprandapyoptional inestimatedAprSchema— Kong hydration only setsaprfor strategy webhook rows (component namekatRewardsAPRcontains "apr" not "apy"), so requiring both caused the entire estimated object to be droppedkatRewardsAPRto recognized componentsSelector (
kongVaultSelectors.ts)estimated.aprwhenestimated.apyis missing, scoped to Katana strategies only (type includes "katana") to avoid changing behavior for other chainskatRewardsAPRfrom strategy estimated performance when type is katana-estimated-aprTKongVaultStrategytypeStrategy UI (
VaultsListStrategy.tsx/VaultStrategiesSection.tsx)katRewardsAPRthrough from section to strategy rowHow to review
Test plan
bun run tslintpassesbun run buildpassesRisk / impact
apr/apyoptional — low risk since.catch(null)handles missing values gracefully